From afd41eaf86ac6b7466a257aebce883d2d5567edd Mon Sep 17 00:00:00 2001 From: Mustafa Kemal Tuna <12192118+lumosmind@users.noreply.github.com> Date: Tue, 12 Jan 2021 05:22:25 +0300 Subject: [PATCH 1/3] each unit parts must be tested For completeness of the test cases we could add tests for the read method. So every method can have individual test cases. --- .../04-object-methods/7-calculator/_js.view/test.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/1-js/04-object-basics/04-object-methods/7-calculator/_js.view/test.js b/1-js/04-object-basics/04-object-methods/7-calculator/_js.view/test.js index 1f71eda4..4decb76d 100644 --- a/1-js/04-object-basics/04-object-methods/7-calculator/_js.view/test.js +++ b/1-js/04-object-basics/04-object-methods/7-calculator/_js.view/test.js @@ -15,6 +15,11 @@ describe("calculator", function() { afterEach(function() { prompt.restore(); }); + + it('the read get two values and saves them as object properties', function () { + assert.equal(calculator.a, 2); + assert.equal(calculator.b, 3); + }); it("the sum is 5", function() { assert.equal(calculator.sum(), 5); From 73fd173f99925c6e28db023623a4e1ac77a6eedc Mon Sep 17 00:00:00 2001 From: Muhammad Bilal Date: Tue, 12 Jan 2021 23:16:01 +0500 Subject: [PATCH 2/3] Update article.md fix spelling of `further` --- 1-js/05-data-types/10-destructuring-assignment/article.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1-js/05-data-types/10-destructuring-assignment/article.md b/1-js/05-data-types/10-destructuring-assignment/article.md index 9f4c3b85..e9077a59 100644 --- a/1-js/05-data-types/10-destructuring-assignment/article.md +++ b/1-js/05-data-types/10-destructuring-assignment/article.md @@ -160,7 +160,7 @@ let [name1, name2] = ["Julius", "Caesar", "Consul", "of the Roman Republic"]; alert(name1); // Julius alert(name2); // Caesar -// Furher items aren't assigned anywhere +// Further items aren't assigned anywhere ``` If we'd like also to gather all that follows -- we can add one more parameter that gets "the rest" using three dots `"..."`: From 09f8ca86592b34ea643b319e4b3eda5d29721d35 Mon Sep 17 00:00:00 2001 From: Mustafa Kemal Tuna <12192118+lumosmind@users.noreply.github.com> Date: Tue, 12 Jan 2021 23:17:01 +0300 Subject: [PATCH 3/3] individual test case for methods to ensure completeness, every method should have their own individual test case. --- .../2-calculator-constructor/_js.view/test.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/1-js/04-object-basics/06-constructor-new/2-calculator-constructor/_js.view/test.js b/1-js/04-object-basics/06-constructor-new/2-calculator-constructor/_js.view/test.js index 03605392..bba80e5c 100644 --- a/1-js/04-object-basics/06-constructor-new/2-calculator-constructor/_js.view/test.js +++ b/1-js/04-object-basics/06-constructor-new/2-calculator-constructor/_js.view/test.js @@ -10,6 +10,11 @@ describe("calculator", function() { calculator = new Calculator(); calculator.read(); }); + + it("the read method asks for two values using prompt and remembers them in object properties", function() { + assert.equal(calculator.a, 2); + assert.equal(calculator.b, 3); + }); it("when 2 and 3 are entered, the sum is 5", function() { assert.equal(calculator.sum(), 5);