From 849d7a3ae1aa858db8547972091b5b6498ce2903 Mon Sep 17 00:00:00 2001 From: Vim Shah Date: Thu, 22 Aug 2019 16:13:24 -0700 Subject: [PATCH 1/5] Update task.md fix typo --- 5-network/01-fetch/01-fetch-users/task.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/5-network/01-fetch/01-fetch-users/task.md b/5-network/01-fetch/01-fetch-users/task.md index 4b42dd9e..4605b495 100644 --- a/5-network/01-fetch/01-fetch-users/task.md +++ b/5-network/01-fetch/01-fetch-users/task.md @@ -1,8 +1,8 @@ # Fetch users from GitHub -Create an async function `getUsers(names)`, that gets an array of GitHub logins, fetche the users from GitHub and returns an array of GitHub users. +Create an async function `getUsers(names)`, that gets an array of GitHub logins, fetches the users from GitHub and returns an array of GitHub users. -The GitHub url with user informaiton for the given `USERNAME` is: `https://api.github.com/users/USERNAME`. +The GitHub url with user information for the given `USERNAME` is: `https://api.github.com/users/USERNAME`. There's a test example in the sandbox. From 78a6ffad05c0b565e775083b9f5c4664a4afa713 Mon Sep 17 00:00:00 2001 From: paroche <46547072+paroche@users.noreply.github.com> Date: Thu, 22 Aug 2019 19:48:21 -0600 Subject: [PATCH 2/5] Update article.md Change to wording about maximum recursion depth. --- 1-js/06-advanced-functions/01-recursion/article.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1-js/06-advanced-functions/01-recursion/article.md b/1-js/06-advanced-functions/01-recursion/article.md index b7758236..9d217653 100644 --- a/1-js/06-advanced-functions/01-recursion/article.md +++ b/1-js/06-advanced-functions/01-recursion/article.md @@ -96,7 +96,7 @@ function pow(x, n) { The maximal number of nested calls (including the first one) is called *recursion depth*. In our case, it will be exactly `n`. -The maximal recursion depth is limited by JavaScript engine. We can make sure about 10000, some engines allow more, but 100000 is probably out of limit for the majority of them. There are automatic optimizations that help alleviate this ("tail calls optimizations"), but they are not yet supported everywhere and work only in simple cases. +The maximal recursion depth is limited by JavaScript engine. We can rely on it being 10000, some engines allow more, but 100000 is probably out of limit for the majority of them. There are automatic optimizations that help alleviate this ("tail calls optimizations"), but they are not yet supported everywhere and work only in simple cases. That limits the application of recursion, but it still remains very wide. There are many tasks where recursive way of thinking gives simpler code, easier to maintain. From d3b5889e65da1e256777e504c2d70212e146ccf1 Mon Sep 17 00:00:00 2001 From: paroche <46547072+paroche@users.noreply.github.com> Date: Fri, 23 Aug 2019 19:55:06 -0600 Subject: [PATCH 3/5] Update article.md --- 1-js/06-advanced-functions/03-closure/article.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1-js/06-advanced-functions/03-closure/article.md b/1-js/06-advanced-functions/03-closure/article.md index f3268441..a39dfc95 100644 --- a/1-js/06-advanced-functions/03-closure/article.md +++ b/1-js/06-advanced-functions/03-closure/article.md @@ -313,7 +313,7 @@ Hopefully, the situation with outer variables is clear now. For most situations ## Environments in detail -Here's what's going on in the `makeCounter` example step-by-step, follow it to make sure that you know things in the very detail. +Here's what's going on in the `makeCounter` example step-by-step, follow it to make sure that you understand how it works in detail. Please note the additional `[[Environment]]` property is covered here. We didn't mention it before for simplicity. From a736f71fb4aa2aeff52f3ce933b84d2ca169cbe4 Mon Sep 17 00:00:00 2001 From: paroche <46547072+paroche@users.noreply.github.com> Date: Sat, 24 Aug 2019 22:40:21 -0600 Subject: [PATCH 4/5] Update article.md Correct spelling of "standardized". --- 1-js/06-advanced-functions/05-global-object/article.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1-js/06-advanced-functions/05-global-object/article.md b/1-js/06-advanced-functions/05-global-object/article.md index 4b82a786..3d195a97 100644 --- a/1-js/06-advanced-functions/05-global-object/article.md +++ b/1-js/06-advanced-functions/05-global-object/article.md @@ -5,7 +5,7 @@ The global object provides variables and functions that are available anywhere. In a browser it is named `window`, for Node.js it is `global`, for other environments it may have another name. -Recently, `globalThis` was added to the language, as a standartized name for a global object, that should be supported across all environments. In some browsers, namely non-Chromium Edge, `globalThis` is not yet supported, but can be easily polyfilled. +Recently, `globalThis` was added to the language, as a standardized name for a global object, that should be supported across all environments. In some browsers, namely non-Chromium Edge, `globalThis` is not yet supported, but can be easily polyfilled. We'll use `window` here, assuming that our environment is a browser. If your script may run in other environments, it's better to use `globalThis` instead. From 812daa9c6bcd8981044684ce9082c8f578d4c84e Mon Sep 17 00:00:00 2001 From: Rizky <41568558+James868@users.noreply.github.com> Date: Mon, 26 Aug 2019 09:24:45 +0000 Subject: [PATCH 5/5] Fix typo --- .../03-dom-navigation/3-navigation-links-which-null/solution.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/2-ui/1-document/03-dom-navigation/3-navigation-links-which-null/solution.md b/2-ui/1-document/03-dom-navigation/3-navigation-links-which-null/solution.md index 266d26b1..d7693632 100644 --- a/2-ui/1-document/03-dom-navigation/3-navigation-links-which-null/solution.md +++ b/2-ui/1-document/03-dom-navigation/3-navigation-links-which-null/solution.md @@ -1,5 +1,5 @@ 1. Yes, true. The element `elem.lastChild` is always the last one, it has no `nextSibling`. -2. No, wrong, because `elem.children[0]` is the first child *among elements*. But there may exist non-element nodes before it. So `previousSibling` may be a text node. Also, if there are no children, then trying to access `elem.children[0]` +2. No, wrong, because `elem.children[0]` is the first child *among elements*. But there may exist non-element nodes before it. So `previousSibling` may be a text node. Please note: for both cases if there are no children, then there will be an error.