From 37761062b4c88ca0ac822ca63a461620d54c5345 Mon Sep 17 00:00:00 2001 From: Prokhor Date: Sun, 28 Oct 2018 15:56:23 +0300 Subject: [PATCH 01/11] min is not defined! Should be: mins --- .../09-class/1-rewrite-to-class/source.view/clock.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1-js/07-object-oriented-programming/09-class/1-rewrite-to-class/source.view/clock.js b/1-js/07-object-oriented-programming/09-class/1-rewrite-to-class/source.view/clock.js index b1a26250..d312c93e 100644 --- a/1-js/07-object-oriented-programming/09-class/1-rewrite-to-class/source.view/clock.js +++ b/1-js/07-object-oriented-programming/09-class/1-rewrite-to-class/source.view/clock.js @@ -11,7 +11,7 @@ Clock.prototype._render = function() { if (hours < 10) hours = '0' + hours; let mins = date.getMinutes(); - if (mins < 10) min = '0' + mins; + if (mins < 10) mins = '0' + mins; let secs = date.getSeconds(); if (secs < 10) secs = '0' + secs; From 6b3b4850384423075219dde7b80a2fdafd914794 Mon Sep 17 00:00:00 2001 From: Prokhor Date: Sun, 28 Oct 2018 15:57:26 +0300 Subject: [PATCH 02/11] Min is not defined Should be: mins --- .../09-class/1-rewrite-to-class/solution.view/clock.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1-js/07-object-oriented-programming/09-class/1-rewrite-to-class/solution.view/clock.js b/1-js/07-object-oriented-programming/09-class/1-rewrite-to-class/solution.view/clock.js index c710b9da..8009273e 100644 --- a/1-js/07-object-oriented-programming/09-class/1-rewrite-to-class/solution.view/clock.js +++ b/1-js/07-object-oriented-programming/09-class/1-rewrite-to-class/solution.view/clock.js @@ -10,7 +10,7 @@ class Clock { if (hours < 10) hours = '0' + hours; let mins = date.getMinutes(); - if (mins < 10) min = '0' + mins; + if (mins < 10) mins = '0' + mins; let secs = date.getSeconds(); if (secs < 10) secs = '0' + secs; From 3601ec366bc4b60c2b5af6ea66e580e0141ecceb Mon Sep 17 00:00:00 2001 From: Prokhor Date: Sun, 28 Oct 2018 15:58:47 +0300 Subject: [PATCH 03/11] Min is not defined Should be: mins --- .../2-clock-class-extended/solution.view/clock.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1-js/07-object-oriented-programming/10-class-inheritance/2-clock-class-extended/solution.view/clock.js b/1-js/07-object-oriented-programming/10-class-inheritance/2-clock-class-extended/solution.view/clock.js index c710b9da..8009273e 100644 --- a/1-js/07-object-oriented-programming/10-class-inheritance/2-clock-class-extended/solution.view/clock.js +++ b/1-js/07-object-oriented-programming/10-class-inheritance/2-clock-class-extended/solution.view/clock.js @@ -10,7 +10,7 @@ class Clock { if (hours < 10) hours = '0' + hours; let mins = date.getMinutes(); - if (mins < 10) min = '0' + mins; + if (mins < 10) mins = '0' + mins; let secs = date.getSeconds(); if (secs < 10) secs = '0' + secs; From 6b0bdac4c027c2e0e6c33e101c5ab266ad3f73b4 Mon Sep 17 00:00:00 2001 From: Prokhor Date: Sun, 28 Oct 2018 15:59:27 +0300 Subject: [PATCH 04/11] Min is not defined Should be: mins --- .../2-clock-class-extended/source.view/clock.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1-js/07-object-oriented-programming/10-class-inheritance/2-clock-class-extended/source.view/clock.js b/1-js/07-object-oriented-programming/10-class-inheritance/2-clock-class-extended/source.view/clock.js index c710b9da..8009273e 100644 --- a/1-js/07-object-oriented-programming/10-class-inheritance/2-clock-class-extended/source.view/clock.js +++ b/1-js/07-object-oriented-programming/10-class-inheritance/2-clock-class-extended/source.view/clock.js @@ -10,7 +10,7 @@ class Clock { if (hours < 10) hours = '0' + hours; let mins = date.getMinutes(); - if (mins < 10) min = '0' + mins; + if (mins < 10) mins = '0' + mins; let secs = date.getSeconds(); if (secs < 10) secs = '0' + secs; From 78dc85424a7d0db58bcac1555e7d824a77269021 Mon Sep 17 00:00:00 2001 From: Prokhor Date: Sun, 28 Oct 2018 16:01:01 +0300 Subject: [PATCH 05/11] Min is not defined Should be: mins --- .../2-rewrite-to-prototypes/solution.view/clock.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1-js/07-object-oriented-programming/08-class-patterns/2-rewrite-to-prototypes/solution.view/clock.js b/1-js/07-object-oriented-programming/08-class-patterns/2-rewrite-to-prototypes/solution.view/clock.js index 7a193b79..c0363448 100644 --- a/1-js/07-object-oriented-programming/08-class-patterns/2-rewrite-to-prototypes/solution.view/clock.js +++ b/1-js/07-object-oriented-programming/08-class-patterns/2-rewrite-to-prototypes/solution.view/clock.js @@ -9,7 +9,7 @@ Clock.prototype._render = function() { if (hours < 10) hours = '0' + hours; let mins = date.getMinutes(); - if (mins < 10) min = '0' + mins; + if (mins < 10) mins = '0' + mins; let secs = date.getSeconds(); if (secs < 10) secs = '0' + secs; From 8aecaa8598434edff2040adec8e1b2c85888697c Mon Sep 17 00:00:00 2001 From: Prokhor Date: Sun, 28 Oct 2018 16:01:29 +0300 Subject: [PATCH 06/11] Min is not defined Should be: mins --- .../2-rewrite-to-prototypes/source.view/clock.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1-js/07-object-oriented-programming/08-class-patterns/2-rewrite-to-prototypes/source.view/clock.js b/1-js/07-object-oriented-programming/08-class-patterns/2-rewrite-to-prototypes/source.view/clock.js index 26081a35..c4bfaa0f 100644 --- a/1-js/07-object-oriented-programming/08-class-patterns/2-rewrite-to-prototypes/source.view/clock.js +++ b/1-js/07-object-oriented-programming/08-class-patterns/2-rewrite-to-prototypes/source.view/clock.js @@ -9,7 +9,7 @@ function Clock({ template }) { if (hours < 10) hours = '0' + hours; let mins = date.getMinutes(); - if (mins < 10) min = '0' + mins; + if (mins < 10) mins = '0' + mins; let secs = date.getSeconds(); if (secs < 10) secs = '0' + secs; From 1d45b45c079066bcb3e7e7712081d088a44eb3ef Mon Sep 17 00:00:00 2001 From: Prokhor Date: Sun, 28 Oct 2018 16:13:33 +0300 Subject: [PATCH 07/11] =?UTF-8?q?A=20spelling=20mistake=20in=20the=20word?= =?UTF-8?q?=20"preferrably"=E2=9D=97=EF=B8=8F?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There must be one character "r". --- 1-js/08-error-handling/1-try-catch/article.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1-js/08-error-handling/1-try-catch/article.md b/1-js/08-error-handling/1-try-catch/article.md index eabfb742..ac3e0031 100644 --- a/1-js/08-error-handling/1-try-catch/article.md +++ b/1-js/08-error-handling/1-try-catch/article.md @@ -255,7 +255,7 @@ The syntax is: throw ``` -Technically, we can use anything as an error object. That may be even a primitive, like a number or a string, but it's better to use objects, preferrably with `name` and `message` properties (to stay somewhat compatible with built-in errors). +Technically, we can use anything as an error object. That may be even a primitive, like a number or a string, but it's better to use objects, preferably with `name` and `message` properties (to stay somewhat compatible with built-in errors). JavaScript has many built-in constructors for standard errors: `Error`, `SyntaxError`, `ReferenceError`, `TypeError` and others. We can use them to create error objects as well. From e4be3724a47c46ca5dfa4c19f5565f02c3bb9e24 Mon Sep 17 00:00:00 2001 From: Prokhor Date: Sun, 28 Oct 2018 16:34:19 +0300 Subject: [PATCH 08/11] `Sticky` too MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "The offsetParent is the nearest ancestor that is: 1. CSS-positioned (position is absolute, relative, fixed…❗️or sticky❗️ --- 2-ui/1-document/09-size-and-scroll/article.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/2-ui/1-document/09-size-and-scroll/article.md b/2-ui/1-document/09-size-and-scroll/article.md index 7b2adb25..da02abdc 100644 --- a/2-ui/1-document/09-size-and-scroll/article.md +++ b/2-ui/1-document/09-size-and-scroll/article.md @@ -60,7 +60,7 @@ These properties are rarely needed, but still they are the "most outer" geometry The `offsetParent` is the nearest ancestor that is: -1. CSS-positioned (`position` is `absolute`, `relative` or `fixed`), +1. CSS-positioned (`position` is `absolute`, `relative`, `fixed` or `sticky`), 2. or ``, ``, ``, 2. or ``. From e92f02a3954a02f69c7314b653aed02e9eb4eed0 Mon Sep 17 00:00:00 2001 From: Prokhor Date: Sun, 28 Oct 2018 16:43:47 +0300 Subject: [PATCH 09/11] excess semicolon excess semicolon after the 'destroy' method --- .../2-hoverintent/solution.view/hoverIntent.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/2-ui/3-event-details/3-mousemove-mouseover-mouseout-mouseenter-mouseleave/2-hoverintent/solution.view/hoverIntent.js b/2-ui/3-event-details/3-mousemove-mouseover-mouseout-mouseenter-mouseleave/2-hoverintent/solution.view/hoverIntent.js index a78c7c55..4e6e2a3e 100644 --- a/2-ui/3-event-details/3-mousemove-mouseover-mouseout-mouseenter-mouseleave/2-hoverintent/solution.view/hoverIntent.js +++ b/2-ui/3-event-details/3-mousemove-mouseover-mouseout-mouseenter-mouseleave/2-hoverintent/solution.view/hoverIntent.js @@ -101,6 +101,6 @@ class HoverIntent { elem.removeEventListener('mousemove', this.onMouseMove); elem.removeEventListener('mouseover', this.onMouseOver); elem.removeEventListener('mouseout', this.onMouseOut); - }; + } } From eb74db5425def5a758552de6e4542426ada1497d Mon Sep 17 00:00:00 2001 From: Prokhor Date: Sun, 28 Oct 2018 16:44:41 +0300 Subject: [PATCH 10/11] excess semicolon excess semicolon after the 'destroy' method --- .../2-hoverintent/source.view/hoverIntent.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/2-ui/3-event-details/3-mousemove-mouseover-mouseout-mouseenter-mouseleave/2-hoverintent/source.view/hoverIntent.js b/2-ui/3-event-details/3-mousemove-mouseover-mouseout-mouseenter-mouseleave/2-hoverintent/source.view/hoverIntent.js index 29198d8e..caca940b 100644 --- a/2-ui/3-event-details/3-mousemove-mouseover-mouseout-mouseenter-mouseleave/2-hoverintent/source.view/hoverIntent.js +++ b/2-ui/3-event-details/3-mousemove-mouseover-mouseout-mouseenter-mouseleave/2-hoverintent/source.view/hoverIntent.js @@ -45,6 +45,6 @@ class HoverIntent { destroy() { /* your code to "disable" the functionality, remove all handlers */ - }; + } } From f488185658d7d3afce5d298a1f2a1a1757e994e3 Mon Sep 17 00:00:00 2001 From: Prokhor Date: Mon, 29 Oct 2018 02:59:28 +0300 Subject: [PATCH 11/11] misspelling MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The page can be divided into four parts: 1. … 2. … 3. … 4. … 5. ??? --- 1-js/03-code-quality/05-testing-mocha/article.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/1-js/03-code-quality/05-testing-mocha/article.md b/1-js/03-code-quality/05-testing-mocha/article.md index 311a0528..02287077 100644 --- a/1-js/03-code-quality/05-testing-mocha/article.md +++ b/1-js/03-code-quality/05-testing-mocha/article.md @@ -96,7 +96,7 @@ The full HTML page with these frameworks and `pow` spec: ```html src="index.html" ``` -The page can be divided into four parts: +The page can be divided into five parts: 1. The `` -- add third-party libraries and styles for tests. 2. The `