From 14dc9ce860b15028502675444064ffd61df6016d Mon Sep 17 00:00:00 2001 From: Naveen Singh <36371707+naveensingh@users.noreply.github.com> Date: Sun, 21 Dec 2025 16:01:53 +0530 Subject: [PATCH] fix: disable address normalization when checking blocked MMS senders (#644) Removed MMS sender address normalization when checking against blocked numbers. Previously, blocking an alphanumeric address such as `VE-ViCARE` would block MMS messages from `VE-ViCARE` and the normalized number `83842273`. Even if that collision never occurs in the real world, removing normalization is the correct move and is consistent with how SMS blocking works. --- CHANGELOG.md | 2 ++ .../main/kotlin/org/fossify/messages/receivers/MmsReceiver.kt | 4 +--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1140cd06..00b904a6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ### Fixed - Fixed missing notifications in some cases ([#159]) +- Fixed incorrect blocking of MMS messages in some rare cases ([#644]) ## [1.7.0] - 2025-12-16 ### Added @@ -221,6 +222,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 [#574]: https://github.com/FossifyOrg/Messages/issues/574 [#600]: https://github.com/FossifyOrg/Messages/issues/600 [#610]: https://github.com/FossifyOrg/Messages/issues/610 +[#644]: https://github.com/FossifyOrg/Messages/issues/644 [Unreleased]: https://github.com/FossifyOrg/Messages/compare/1.7.0...HEAD [1.7.0]: https://github.com/FossifyOrg/Messages/compare/1.6.0...1.7.0 diff --git a/app/src/main/kotlin/org/fossify/messages/receivers/MmsReceiver.kt b/app/src/main/kotlin/org/fossify/messages/receivers/MmsReceiver.kt index 04ad1e60..54a7c422 100644 --- a/app/src/main/kotlin/org/fossify/messages/receivers/MmsReceiver.kt +++ b/app/src/main/kotlin/org/fossify/messages/receivers/MmsReceiver.kt @@ -7,7 +7,6 @@ import com.klinker.android.send_message.MmsReceivedReceiver import org.fossify.commons.extensions.baseConfig import org.fossify.commons.extensions.getMyContactsCursor import org.fossify.commons.extensions.isNumberBlocked -import org.fossify.commons.extensions.normalizePhoneNumber import org.fossify.commons.extensions.showErrorToast import org.fossify.commons.helpers.SimpleContactsHelper import org.fossify.commons.helpers.ensureBackgroundThread @@ -27,8 +26,7 @@ import org.fossify.messages.models.Message class MmsReceiver : MmsReceivedReceiver() { override fun isAddressBlocked(context: Context, address: String): Boolean { - val normalizedAddress = address.normalizePhoneNumber() - if (context.isNumberBlocked(normalizedAddress)) return true + if (context.isNumberBlocked(address)) return true if (context.baseConfig.blockUnknownNumbers) { context.getMyContactsCursor(favoritesOnly = false, withPhoneNumbersOnly = true).use { val isKnownContact = SimpleContactsHelper(context).existsSync(address, it)