From 72e5cbac3c58926ac51c6b64a3cf6042bad1686f Mon Sep 17 00:00:00 2001
From: Naveen Singh <snaveen935@gmail.com>
Date: Tue, 1 Apr 2025 12:20:43 +0530
Subject: [PATCH] Make conversation screen scrollable

See https://github.com/FossifyOrg/Messages/issues/359
---
 .../activities/ConversationDetailsActivity.kt |   2 +-
 .../layout/activity_conversation_details.xml  | 175 +++++++++---------
 2 files changed, 93 insertions(+), 84 deletions(-)

diff --git a/app/src/main/kotlin/org/fossify/messages/activities/ConversationDetailsActivity.kt b/app/src/main/kotlin/org/fossify/messages/activities/ConversationDetailsActivity.kt
index 76a2c64c..be2eeeed 100644
--- a/app/src/main/kotlin/org/fossify/messages/activities/ConversationDetailsActivity.kt
+++ b/app/src/main/kotlin/org/fossify/messages/activities/ConversationDetailsActivity.kt
@@ -54,7 +54,7 @@ class ConversationDetailsActivity : SimpleActivity() {
             useTopSearchMenu = false
         )
         setupMaterialScrollListener(
-            scrollingView = binding.participantsRecyclerview,
+            scrollingView = binding.conversationDetailsNestedScrollview,
             toolbar = binding.conversationDetailsToolbar
         )
 
diff --git a/app/src/main/res/layout/activity_conversation_details.xml b/app/src/main/res/layout/activity_conversation_details.xml
index c3582f39..e648dc32 100644
--- a/app/src/main/res/layout/activity_conversation_details.xml
+++ b/app/src/main/res/layout/activity_conversation_details.xml
@@ -14,94 +14,103 @@
         app:title="@string/conversation_details"
         app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
 
-    <LinearLayout
-        android:id="@+id/conversation_details_holder"
+    <androidx.core.widget.NestedScrollView
+        android:id="@+id/conversation_details_nested_scrollview"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:layout_marginTop="?attr/actionBarSize"
-        android:orientation="vertical">
+        android:fillViewport="true"
+        android:scrollbars="none">
 
-        <TextView
-            android:id="@+id/notifications_heading"
-            style="@style/SettingsSectionLabelStyle"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:text="@string/notifications"
-            android:visibility="gone"
-            tools:visibility="visible" />
-
-        <RelativeLayout
-            android:id="@+id/custom_notifications_holder"
-            style="@style/SettingsHolderSwitchStyle"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:visibility="gone"
-            tools:visibility="visible">
-
-            <org.fossify.commons.views.MyMaterialSwitch
-                android:id="@+id/custom_notifications"
-                style="@style/SettingsSwitchStyle"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
-                android:text="@string/enable_custom_notifications" />
-
-        </RelativeLayout>
-
-        <org.fossify.commons.views.MyTextView
-            android:id="@+id/custom_notifications_button"
-            style="@style/SettingsHolderTextViewOneLinerStyle"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:text="@string/customize_notifications"
-            android:visibility="gone"
-            tools:visibility="visible" />
-
-        <include
-            android:id="@+id/settings_conversation_notifications_divider"
-            layout="@layout/divider" />
-
-        <TextView
-            android:id="@+id/conversation_name_heading"
-            style="@style/SettingsSectionLabelStyle"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:text="@string/conversation_name" />
-
-        <org.fossify.commons.views.MyTextView
-            android:id="@+id/conversation_name"
-            style="@style/SettingsHolderTextViewOneLinerStyle"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:background="?attr/selectableItemBackground"
-            android:clickable="true"
-            android:drawableEnd="@drawable/ic_edit_vector"
-            android:drawablePadding="@dimen/bigger_margin"
-            android:ellipsize="end"
-            android:focusable="true"
-            android:maxLines="1"
-            android:textSize="@dimen/bigger_text_size"
-            tools:text="Conversation name" />
-
-        <include
-            android:id="@+id/settings_conversation_name_divider"
-            layout="@layout/divider" />
-
-        <TextView
-            android:id="@+id/members_heading"
-            style="@style/SettingsSectionLabelStyle"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:text="@string/members" />
-
-        <org.fossify.commons.views.MyRecyclerView
-            android:id="@+id/participants_recyclerview"
+        <LinearLayout
+            android:id="@+id/conversation_details_holder"
             android:layout_width="match_parent"
             android:layout_height="match_parent"
-            android:layout_marginTop="@dimen/medium_margin"
-            android:clipToPadding="false"
-            app:layoutManager="org.fossify.commons.views.MyLinearLayoutManager"
-            tools:itemCount="3"
-            tools:listitem="@layout/item_contact_with_number" />
+            android:orientation="vertical">
 
-    </LinearLayout>
+            <TextView
+                android:id="@+id/notifications_heading"
+                style="@style/SettingsSectionLabelStyle"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:text="@string/notifications"
+                android:visibility="gone"
+                tools:visibility="visible" />
+
+            <RelativeLayout
+                android:id="@+id/custom_notifications_holder"
+                style="@style/SettingsHolderSwitchStyle"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:visibility="gone"
+                tools:visibility="visible">
+
+                <org.fossify.commons.views.MyMaterialSwitch
+                    android:id="@+id/custom_notifications"
+                    style="@style/SettingsSwitchStyle"
+                    android:layout_width="match_parent"
+                    android:layout_height="wrap_content"
+                    android:text="@string/enable_custom_notifications" />
+
+            </RelativeLayout>
+
+            <org.fossify.commons.views.MyTextView
+                android:id="@+id/custom_notifications_button"
+                style="@style/SettingsHolderTextViewOneLinerStyle"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:text="@string/customize_notifications"
+                android:visibility="gone"
+                tools:visibility="visible" />
+
+            <include
+                android:id="@+id/settings_conversation_notifications_divider"
+                layout="@layout/divider" />
+
+            <TextView
+                android:id="@+id/conversation_name_heading"
+                style="@style/SettingsSectionLabelStyle"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:text="@string/conversation_name" />
+
+            <org.fossify.commons.views.MyTextView
+                android:id="@+id/conversation_name"
+                style="@style/SettingsHolderTextViewOneLinerStyle"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:background="?attr/selectableItemBackground"
+                android:clickable="true"
+                android:drawableEnd="@drawable/ic_edit_vector"
+                android:drawablePadding="@dimen/bigger_margin"
+                android:ellipsize="end"
+                android:focusable="true"
+                android:maxLines="1"
+                android:textSize="@dimen/bigger_text_size"
+                tools:text="Conversation name" />
+
+            <include
+                android:id="@+id/settings_conversation_name_divider"
+                layout="@layout/divider" />
+
+            <TextView
+                android:id="@+id/members_heading"
+                style="@style/SettingsSectionLabelStyle"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:text="@string/members" />
+
+            <org.fossify.commons.views.MyRecyclerView
+                android:id="@+id/participants_recyclerview"
+                android:layout_width="match_parent"
+                android:layout_height="match_parent"
+                android:layout_marginTop="@dimen/medium_margin"
+                android:clipToPadding="false"
+                app:layoutManager="org.fossify.commons.views.MyLinearLayoutManager"
+                tools:itemCount="3"
+                tools:listitem="@layout/item_contact_with_number" />
+
+        </LinearLayout>
+
+    </androidx.core.widget.NestedScrollView>
 </androidx.coordinatorlayout.widget.CoordinatorLayout>