From 91791254768f7a2d071d7e9968b6435aedc761a1 Mon Sep 17 00:00:00 2001 From: Naveen Date: Tue, 30 Aug 2022 19:35:00 +0530 Subject: [PATCH] Use `sendEmailIntent` extension from commons --- app/build.gradle | 2 +- .../activities/VCardViewerActivity.kt | 4 ++-- .../smsmessenger/extensions/Activity.kt | 16 ---------------- 3 files changed, 3 insertions(+), 19 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 043d29a2..9e4b754f 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -63,7 +63,7 @@ android { } dependencies { - implementation 'com.github.SimpleMobileTools:Simple-Commons:2122bbc6a3' + implementation 'com.github.SimpleMobileTools:Simple-Commons:141660c8f9' implementation 'org.greenrobot:eventbus:3.3.1' implementation 'com.github.tibbi:IndicatorFastScroll:4524cd0b61' implementation 'com.github.tibbi:android-smsmms:4cdacdb701' diff --git a/app/src/main/kotlin/com/simplemobiletools/smsmessenger/activities/VCardViewerActivity.kt b/app/src/main/kotlin/com/simplemobiletools/smsmessenger/activities/VCardViewerActivity.kt index b8f2296b..f643b8a4 100644 --- a/app/src/main/kotlin/com/simplemobiletools/smsmessenger/activities/VCardViewerActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/smsmessenger/activities/VCardViewerActivity.kt @@ -4,11 +4,11 @@ import android.content.Intent import android.net.Uri import android.os.Bundle import com.simplemobiletools.commons.extensions.normalizePhoneNumber +import com.simplemobiletools.commons.extensions.sendEmailIntent import com.simplemobiletools.commons.helpers.NavigationIcon import com.simplemobiletools.smsmessenger.R import com.simplemobiletools.smsmessenger.adapters.VCardViewerAdapter import com.simplemobiletools.smsmessenger.extensions.dialNumber -import com.simplemobiletools.smsmessenger.extensions.sendMail import com.simplemobiletools.smsmessenger.helpers.EXTRA_VCARD_URI import com.simplemobiletools.smsmessenger.helpers.parseVCardFromUri import com.simplemobiletools.smsmessenger.models.VCardPropertyWrapper @@ -71,7 +71,7 @@ class VCardViewerActivity : SimpleActivity() { private fun handleClick(property: VCardPropertyWrapper) { when (property.property) { is Telephone -> dialNumber(property.value.normalizePhoneNumber()) - is Email -> sendMail(property.value) + is Email -> sendEmailIntent(property.value) } } diff --git a/app/src/main/kotlin/com/simplemobiletools/smsmessenger/extensions/Activity.kt b/app/src/main/kotlin/com/simplemobiletools/smsmessenger/extensions/Activity.kt index e6200b49..1d165091 100644 --- a/app/src/main/kotlin/com/simplemobiletools/smsmessenger/extensions/Activity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/smsmessenger/extensions/Activity.kt @@ -24,19 +24,3 @@ fun Activity.dialNumber(phoneNumber: String, callback: (() -> Unit)? = null) { } } } - -fun Activity.sendMail(email: String) { - hideKeyboard() - Intent(Intent.ACTION_SENDTO).apply { - data = Uri.parse("mailto:") - putExtra(Intent.EXTRA_EMAIL, email) - - try { - startActivity(this) - } catch (e: ActivityNotFoundException) { - toast(R.string.no_app_found) - } catch (e: Exception) { - showErrorToast(e) - } - } -}