From efc95ef9f6ebc344d174302dd85a5436117ba7f1 Mon Sep 17 00:00:00 2001 From: tibbi Date: Sat, 13 Nov 2021 10:10:42 +0100 Subject: [PATCH] updating the Settings style --- app/build.gradle | 2 +- .../activities/SettingsActivity.kt | 27 +- app/src/main/res/layout/activity_settings.xml | 491 +++++++++--------- app/src/main/res/menu/menu_main.xml | 6 +- 4 files changed, 268 insertions(+), 258 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 2b3ffcc9..92e00249 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -56,7 +56,7 @@ android { } dependencies { - implementation 'com.github.SimpleMobileTools:Simple-Commons:4222d24832' + implementation 'com.github.SimpleMobileTools:Simple-Commons:a8c7dfd635' implementation 'org.greenrobot:eventbus:3.2.0' implementation 'com.klinkerapps:android-smsmms:5.2.6' implementation 'com.github.tibbi:IndicatorFastScroll:c3de1d040a' diff --git a/app/src/main/kotlin/com/simplemobiletools/smsmessenger/activities/SettingsActivity.kt b/app/src/main/kotlin/com/simplemobiletools/smsmessenger/activities/SettingsActivity.kt index 999855fe..560f5987 100644 --- a/app/src/main/kotlin/com/simplemobiletools/smsmessenger/activities/SettingsActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/smsmessenger/activities/SettingsActivity.kt @@ -16,8 +16,8 @@ import com.simplemobiletools.smsmessenger.extensions.config import com.simplemobiletools.smsmessenger.extensions.getLockScreenVisibilityText import com.simplemobiletools.smsmessenger.extensions.getMMSFileLimitText import com.simplemobiletools.smsmessenger.helpers.* -import java.util.* import kotlinx.android.synthetic.main.activity_settings.* +import java.util.* class SettingsActivity : SimpleActivity() { private var blockedNumbersAtPause = -1 @@ -47,6 +47,19 @@ class SettingsActivity : SimpleActivity() { if (blockedNumbersAtPause != -1 && blockedNumbersAtPause != getBlockedNumbers().hashCode()) { refreshMessages() } + + arrayOf(settings_color_customization_label, settings_general_settings_label, settings_outgoing_messages_label, settings_notifications_label).forEach { + it.setTextColor(getAdjustedPrimaryColor()) + } + + arrayOf( + settings_color_customization_holder, + settings_general_settings_holder, + settings_outgoing_messages_holder, + settings_notifications_holder + ).forEach { + it.background.applyColorFilter(baseConfig.backgroundColor.getContrastColor()) + } } override fun onPause() { @@ -61,6 +74,12 @@ class SettingsActivity : SimpleActivity() { private fun setupPurchaseThankYou() { settings_purchase_thank_you_holder.beGoneIf(isOrWasThankYouInstalled()) + + // make sure the corners at ripple fit the stroke rounded corners + if (settings_purchase_thank_you_holder.isGone()) { + settings_use_english_holder.background = resources.getDrawable(R.drawable.ripple_top_corners, theme) + } + settings_purchase_thank_you_holder.setOnClickListener { launchPurchaseThankYouIntent() } @@ -83,6 +102,11 @@ class SettingsActivity : SimpleActivity() { private fun setupUseEnglish() { settings_use_english_holder.beVisibleIf(config.wasUseEnglishToggled || Locale.getDefault().language != "en") settings_use_english.isChecked = config.useEnglish + + if (settings_use_english_holder.isGone() && settings_purchase_thank_you_holder.isGone()) { + settings_change_date_time_format_holder.background = resources.getDrawable(R.drawable.ripple_top_corners, theme) + } + settings_use_english_holder.setOnClickListener { settings_use_english.toggle() config.useEnglish = settings_use_english.isChecked @@ -131,6 +155,7 @@ class SettingsActivity : SimpleActivity() { config.showCharacterCounter = settings_show_character_counter.isChecked } } + private fun setupUseSimpleCharacters() { settings_use_simple_characters.isChecked = config.useSimpleCharacters settings_use_simple_characters_holder.setOnClickListener { diff --git a/app/src/main/res/layout/activity_settings.xml b/app/src/main/res/layout/activity_settings.xml index 77283b63..1ac90336 100644 --- a/app/src/main/res/layout/activity_settings.xml +++ b/app/src/main/res/layout/activity_settings.xml @@ -1,6 +1,5 @@ - + android:text="@string/color_customization" /> - - - - - + android:layout_margin="@dimen/medium_margin" + android:background="@drawable/section_holder_stroke" + android:orientation="vertical"> - - - - - - - - - - - - - - - - - - - - - - - - - + android:background="@drawable/ripple_all_corners"> - + - + + + + android:text="@string/notifications" /> - - - - - - - + android:layout_margin="@dimen/medium_margin" + android:background="@drawable/section_holder_stroke" + android:orientation="vertical"> - + android:background="@drawable/ripple_top_corners"> - + - + + + + + + + + + + + + android:text="@string/general_settings" /> - - - - - + android:layout_margin="@dimen/medium_margin" + android:background="@drawable/section_holder_stroke" + android:orientation="vertical"> - + android:background="@drawable/ripple_top_corners"> - + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + android:text="@string/outgoing_messages" /> - - - - - - - + android:layout_margin="@dimen/medium_margin" + android:background="@drawable/section_holder_stroke" + android:orientation="vertical"> - + android:background="@drawable/ripple_top_corners"> - + + + + + android:background="@drawable/ripple_background"> - + + + + + + + + + + + + + + + + + + diff --git a/app/src/main/res/menu/menu_main.xml b/app/src/main/res/menu/menu_main.xml index 70a319fe..96972865 100644 --- a/app/src/main/res/menu/menu_main.xml +++ b/app/src/main/res/menu/menu_main.xml @@ -16,10 +16,12 @@ app:showAsAction="never" /> + app:showAsAction="ifRoom" /> + app:showAsAction="ifRoom" />