From 3441b9cc451fce7baf1cc03cd4599405a192ca6b Mon Sep 17 00:00:00 2001 From: Micke Prag Date: Tue, 4 Dec 2012 17:25:17 +0100 Subject: [PATCH] Missing username in TODO according to Google style guidelines "readability/todo" --- telldus-core/client/Client.cpp | 2 +- telldus-core/common/Socket_win.cpp | 2 +- telldus-core/service/SettingsWinRegistry.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/telldus-core/client/Client.cpp b/telldus-core/client/Client.cpp index f998886e..2224a626 100644 --- a/telldus-core/client/Client.cpp +++ b/telldus-core/client/Client.cpp @@ -171,7 +171,7 @@ std::wstring Client::sendToService(const Message &msg) { debuglog(555, "Error in write, should retry"); continue; //retry } - readData = s.read(1000); //TODO changed to 10000 from 5000, how much does this do...? + readData = s.read(1000); // TODO(stefan): changed to 10000 from 5000, how much does this do...? if(readData == L""){ msleep(500); continue; // TODO(stefan): can we be really sure it SHOULD be anything? diff --git a/telldus-core/common/Socket_win.cpp b/telldus-core/common/Socket_win.cpp index b112ff97..5724d9ed 100644 --- a/telldus-core/common/Socket_win.cpp +++ b/telldus-core/common/Socket_win.cpp @@ -140,7 +140,7 @@ std::wstring Socket::read(int timeout){ if (err == ERROR_BROKEN_PIPE){ debuglog(static_cast(err), "Got an error, close this socket"); d->connected = false; - break; //TODO is this correct? + break; // TODO(stefan): is this correct? } } returnString.append(buf); diff --git a/telldus-core/service/SettingsWinRegistry.cpp b/telldus-core/service/SettingsWinRegistry.cpp index 7debf9eb..f173be86 100644 --- a/telldus-core/service/SettingsWinRegistry.cpp +++ b/telldus-core/service/SettingsWinRegistry.cpp @@ -253,7 +253,7 @@ int Settings::getIntSetting(Node type, int intNodeId, const std::wstring &name, std::wstring strSetting = getStringSetting(type, intNodeId, name, parameter); if (strSetting.length()) { - intReturn = static_cast(strSetting[0]); //TODO: do real conversion instead + intReturn = static_cast(strSetting[0]); // TODO(micke): do real conversion instead } return intReturn;