From 6688f44084c7b933fe6dd960c58567944d1023fc Mon Sep 17 00:00:00 2001 From: Micke Prag Date: Fri, 15 Jun 2012 17:18:05 +0200 Subject: [PATCH] Missing username in TODO according to Google style guidelines "readability/todo" --- telldus-core/client/Client.cpp | 6 +++--- telldus-core/common/Socket_unix.cpp | 2 +- telldus-core/common/Strings.cpp | 2 +- telldus-core/service/ControllerManager.cpp | 4 ++-- telldus-core/service/DeviceManager.cpp | 2 +- telldus-core/service/ProtocolNexa.cpp | 2 +- telldus-core/service/ProtocolOregon.cpp | 2 +- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/telldus-core/client/Client.cpp b/telldus-core/client/Client.cpp index 521906d6..d8c2b6d1 100644 --- a/telldus-core/client/Client.cpp +++ b/telldus-core/client/Client.cpp @@ -166,11 +166,11 @@ std::wstring Client::sendToService(const Message &msg) { msleep(500); continue; // retry } - readData = s.read(8000); // TODO changed to 10000 from 5000, how much does this do...? + readData = s.read(8000); // TODO(stefan) changed to 10000 from 5000, how much does this do...? if(readData == L"") { msleep(500); - continue; // TODO can we be really sure it SHOULD be anything? - // TODO perhaps break here instead? + continue; // TODO(stefan): can we be really sure it SHOULD be anything? + // TODO(stefan): perhaps break here instead? } if (!s.isConnected()) { // Connection failed sometime during operation... diff --git a/telldus-core/common/Socket_unix.cpp b/telldus-core/common/Socket_unix.cpp index b837c507..0e62d13e 100644 --- a/telldus-core/common/Socket_unix.cpp +++ b/telldus-core/common/Socket_unix.cpp @@ -121,7 +121,7 @@ std::wstring Socket::read(int timeout) { void Socket::stopReadWait() { TelldusCore::MutexLocker locker(&d->mutex); d->connected = false; - // TODO somehow signal the socket here? + // TODO(stefan): somehow signal the socket here? } void Socket::write(const std::wstring &msg) { diff --git a/telldus-core/common/Strings.cpp b/telldus-core/common/Strings.cpp index d29ee203..b1221ff4 100644 --- a/telldus-core/common/Strings.cpp +++ b/telldus-core/common/Strings.cpp @@ -101,7 +101,7 @@ bool TelldusCore::comparei(std::wstring stringA, std::wstring stringB) { std::wstring TelldusCore::intToWstring(int value) { #ifdef _WINDOWS // no stream used - // TODO! Make effective and safe... + // TODO(stefan): Make effective and safe... wchar_t numstr[21]; // enough to hold all numbers up to 64-bits _itow_s(value, numstr, sizeof(numstr), 10); std::wstring newstring(numstr); diff --git a/telldus-core/service/ControllerManager.cpp b/telldus-core/service/ControllerManager.cpp index b1ce2ce1..0cc90a99 100644 --- a/telldus-core/service/ControllerManager.cpp +++ b/telldus-core/service/ControllerManager.cpp @@ -174,7 +174,7 @@ void ControllerManager::loadControllers() { if (!controllerId) { controllerId = d->settings.addNode(Settings::Controller); if(controllerId < 0) { - // TODO: How to handle this? + // TODO(micke): How to handle this? continue; } isNew = true; @@ -333,7 +333,7 @@ int ControllerManager::setControllerValue(int id, const std::wstring &name, cons d->settings.setName(Settings::Controller, id, value); signalControllerEvent(id, TELLSTICK_DEVICE_CHANGED, TELLSTICK_CHANGE_NAME, value); } else { - return TELLSTICK_ERROR_SYNTAX; // TODO: Is this the best error? + return TELLSTICK_ERROR_SYNTAX; // TODO(micke): Is this the best error? } return TELLSTICK_SUCCESS; } diff --git a/telldus-core/service/DeviceManager.cpp b/telldus-core/service/DeviceManager.cpp index f17cc5a5..09ff7a7b 100644 --- a/telldus-core/service/DeviceManager.cpp +++ b/telldus-core/service/DeviceManager.cpp @@ -487,7 +487,7 @@ int DeviceManager::doGroupAction(const std::wstring devices, const int action, c if(childType == TELLSTICK_TYPE_DEVICE) { deviceReturnValue = doAction(deviceId, action, data); } else if(childType == TELLSTICK_TYPE_SCENE) { - deviceReturnValue = doGroupAction(DeviceManager::getDeviceParameter(deviceId, L"devices", L""), action, data, childType, deviceId, duplicateDeviceIds); // TODO make scenes infinite loops-safe + deviceReturnValue = doGroupAction(DeviceManager::getDeviceParameter(deviceId, L"devices", L""), action, data, childType, deviceId, duplicateDeviceIds); // TODO(stefan) make scenes infinite loops-safe } else { // group (in group) deviceReturnValue = doGroupAction(DeviceManager::getDeviceParameter(deviceId, L"devices", L""), action, data, childType, deviceId, duplicateDeviceIds); diff --git a/telldus-core/service/ProtocolNexa.cpp b/telldus-core/service/ProtocolNexa.cpp index 3965b2b7..baad51cc 100644 --- a/telldus-core/service/ProtocolNexa.cpp +++ b/telldus-core/service/ProtocolNexa.cpp @@ -11,7 +11,7 @@ #include "service/TellStick.h" #include "common/Strings.h" -int ProtocolNexa::lastArctecCodeSwitchWasTurnOff = 0; // TODO, always removing first turnon now, make more flexible (waveman too) +int ProtocolNexa::lastArctecCodeSwitchWasTurnOff = 0; // TODO(stefan): always removing first turnon now, make more flexible (waveman too) int ProtocolNexa::methods() const { if (TelldusCore::comparei(model(), L"codeswitch")) { diff --git a/telldus-core/service/ProtocolOregon.cpp b/telldus-core/service/ProtocolOregon.cpp index b1eedb6b..3c397651 100644 --- a/telldus-core/service/ProtocolOregon.cpp +++ b/telldus-core/service/ProtocolOregon.cpp @@ -103,7 +103,7 @@ std::string ProtocolOregon::decode1A2D(const std::string &data) { checksum += 0x1 + 0xA + 0x2 + 0xD - 0xA; - // TODO: Find out how checksum2 works + // TODO(micke): Find out how checksum2 works if (checksum != checksum1) { return ""; }