jeena/en.javascript.info
1
0
Fork 0
Code Issues Pull requests Projects Packages Wiki Activity Actions

Merge pull request #141 from nhooyr/patch-1

Browse source 
Safari does not return an empty string when a prompt is cancelled
This commit is contained in:
Ilya Kantor 2017-08-18 12:09:49 +02:00 • committed by GitHub
commit 25e97bb50e
1 changed files with 3 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

12
1-js/02-first-steps/10-ifelse/4-check-login/solution.md
View file

@ -9,23 +9,17 @@ if (userName == 'Admin') {
if (pass == 'TheMaster') {
alert( 'Welcome!' );
} else if (pass == null || pass == '') { // (*)
} else if (pass == null) {
alert( 'Canceled.' );
} else {
alert( 'Wrong password' );
}
} else if (userName == null || userName == '') { // (**)
} else if (userName == null) {
alert( 'Canceled' );
} else {
alert( "I don't know you" );
}
```
Please note the `if` check in lines `(*)` and `(**)`. Every browser except Safari returns `null` when the input is canceled, and Safari returns an empty string. So we must treat them same for compatibility.
Also note the vertical indents inside the `if` blocks. They are technically not required, but make the code more readable.
Note the vertical indents inside the `if` blocks. They are technically not required, but make the code more readable.