jeena/en.javascript.info
1
0
Fork 0
Code Issues Pull requests Projects Packages Wiki Activity Actions

Merge pull request #964 from rezyx/fix-github-casing

Browse source 
Fix GitHub casing (04-promise-error-handling/article.md
This commit is contained in:
Alexey Pyltsyn 2019-05-06 23:06:47 +03:00 • committed by GitHub
commit 40074e0186
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
1-js/11-async/04-promise-error-handling/article.md
View file

@ -169,7 +169,7 @@ Let's improve error handling for the user-loading example.
The promise returned by [fetch](mdn:api/WindowOrWorkerGlobalScope/fetch) rejects when it's impossible to make a request. For instance, a remote server is not available, or the URL is malformed. But if the remote server responds with error 404, or even error 500, then it's considered a valid response. The promise returned by [fetch](mdn:api/WindowOrWorkerGlobalScope/fetch) rejects when it's impossible to make a request. For instance, a remote server is not available, or the URL is malformed. But if the remote server responds with error 404, or even error 500, then it's considered a valid response.
What if the server returns a non-JSON page with error 500 in the line `(*)`? What if there's no such user, and github returns a page with error 404 at `(**)`? What if the server returns a non-JSON page with error 500 in the line `(*)`? What if there's no such user, and GitHub returns a page with error 404 at `(**)`?
```js run ```js run
fetch('no-such-user.json') // (*) fetch('no-such-user.json') // (*)
@ -219,7 +219,7 @@ The great thing about having our own class for errors is that we can easily chec
For instance, we can make a request, and then if we get 404 -- ask the user to modify the information. For instance, we can make a request, and then if we get 404 -- ask the user to modify the information.
The code below loads a user with the given name from github. If there's no such user, then it asks for the correct name: The code below loads a user with the given name from GitHub. If there's no such user, then it asks for the correct name:
```js run ```js run
function demoGithubUser() { function demoGithubUser() {