Merge pull request #895 from holub008/master

Mismatched example code and image in promise basics
This commit is contained in:
Ilya Kantor 2019-04-09 23:37:56 +03:00 committed by GitHub
commit 67ed0e01c8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -48,8 +48,8 @@ Here's an example of a Promise constructor and a simple executor function with i
let promise = new Promise(function(resolve, reject) { let promise = new Promise(function(resolve, reject) {
// the function is executed automatically when the promise is constructed // the function is executed automatically when the promise is constructed
// after 1 second signal that the job is done with the result "done!" // after 1 second signal that the job is done with the result "done"
setTimeout(() => *!*resolve("done!")*/!*, 1000); setTimeout(() => *!*resolve("done")*/!*, 1000);
}); });
``` ```
@ -58,7 +58,7 @@ We can see two things by running the code above:
1. The executor is called automatically and immediately (by the `new Promise`). 1. The executor is called automatically and immediately (by the `new Promise`).
2. The executor receives two arguments: `resolve` and `reject` — these functions are pre-defined by the JavaScript engine. So we don't need to create them. Instead, we should write the executor to call them when ready. 2. The executor receives two arguments: `resolve` and `reject` — these functions are pre-defined by the JavaScript engine. So we don't need to create them. Instead, we should write the executor to call them when ready.
After one second of "processing" the executor calls `resolve("done!")` to produce the result: After one second of "processing" the executor calls `resolve("done")` to produce the result:
![](promise-resolve-1.png) ![](promise-resolve-1.png)