Merge branch 'master' into patch-1

This commit is contained in:
Ilya Kantor 2018-09-30 23:48:25 +03:00 committed by GitHub
commit c771595a32
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 23 additions and 21 deletions

View file

@ -262,7 +262,7 @@ function step3(error, script) {
See? It does the same, and there's no deep nesting now, because we made every action a separate top-level function.
It works, but the code looks like a torn apart spreadsheet. It's difficult to read, you probably noticed that. One needs to eye-jump between pieces while reading it. That's inconvenient, especially the reader is not familiar with the code and doesn't know where to eye-jump.
It works, but the code looks like a torn apart spreadsheet. It's difficult to read, you probably noticed that. One needs to eye-jump between pieces while reading it. That's inconvenient, especially if the reader is not familiar with the code and doesn't know where to eye-jump.
Also the functions named `step*` are all of a single use, they are created only to avoid the "pyramid of doom". No one is going to reuse them outside of the action chain. So there's a bit of a namespace cluttering here.