Ilya Kantor
fd08e1c20c
Merge pull request #2279 from lumosmind/patch-53
...
look like ninja code
2020-11-11 17:59:12 +03:00
Ilya Kantor
29a7b6677e
Update article.md
2020-11-11 17:57:38 +03:00
Vse Mozhe Buty
59a2f34123
Fix a typo in 1.11.3 (Promises chaining)
...
Refs: https://github.com/javascript-tutorial/en.javascript.info/pull/2252#issuecomment-724565094
2020-11-10 13:03:41 +00:00
Mustafa Kemal Tuna
a4194ceeff
look like ninja code
...
It can be more readable with same line of code. There was a lot of nested parenthesis.
2020-11-10 15:45:14 +03:00
Ilya Kantor
96b98541a3
Merge pull request #2258 from vsemozhetbyt/patch-12
...
Fix typo in 1.11.6 (Promisification)
2020-11-10 12:05:25 +03:00
Ilya Kantor
48b111d85f
Merge pull request #2257 from vsemozhetbyt/1.11.8
...
Fix semicolons, remove old note in 1.11.8
2020-11-10 12:05:14 +03:00
Ilya Kantor
2ff5eeb95a
Merge pull request #2255 from vsemozhetbyt/patch-11
...
Fix semicolons in 1.11.6 (Promisification)
2020-11-10 12:04:26 +03:00
Ilya Kantor
ca9a0225e1
Revert "Fix a typo in 1.11.3 (Promises chaining)"
2020-11-10 12:03:31 +03:00
Ilya Kantor
12a5cb02d7
Merge pull request #2252 from vsemozhetbyt/patch-10
...
Fix a typo in 1.11.3 (Promises chaining)
2020-11-10 12:03:16 +03:00
Ilya Kantor
9e99c367ab
Merge pull request #2249 from vsemozhetbyt/patch-9
...
Fix semicolons in 1.11.1 (Introduction: callbacks)
2020-11-09 13:28:19 +03:00
Vse Mozhe Buty
58d9f752b6
Fix typo in 1.11.6 (Promisification)
2020-11-01 03:03:36 +02:00
Vse Mozhe Buty
37c6a31de5
Fix semicolons, remove old note in 1.11.8
2020-11-01 01:45:02 +02:00
Ilya Kantor
9a6a9fb584
Update article.md
2020-11-01 00:16:29 +03:00
Vse Mozhe Buty
d5a88b6b2a
Fix semicolons in 1.11.6 (Promisification)
2020-10-31 18:10:32 +02:00
Vse Mozhe Buty
1236996ba1
Fix a typo in 1.11.3 (Promises chaining)
2020-10-31 12:57:05 +02:00
Vse Mozhe Buty
2f822c8ec3
Fix semicolons in 1.11.1 (Introduction: callbacks)
2020-10-30 18:01:51 +02:00
Ilya Kantor
0c760be1ee
Update task.md
2020-10-29 19:49:40 +03:00
Herrera-pgoat
58ee49a958
Update task.md
...
Made it clear what the question was asking from the user.
2020-10-22 16:05:32 -05:00
Ilya Kantor
e9686467e6
minor fixes, close #2137
2020-09-24 11:55:34 +03:00
Ilya Kantor
7907cd667c
minor fixes
2020-08-04 10:33:40 +03:00
Ilya Kantor
f0ad0bafa2
minor fixes
2020-08-04 10:30:25 +03:00
Ilya Kantor
fb4dda68e5
minor fixes
2020-08-04 10:30:13 +03:00
Ilya Kantor
d2f7d14288
minor fixes
2020-08-04 10:29:38 +03:00
Ilya Kantor
0e592a95c7
minor fixes
2020-08-04 10:29:29 +03:00
Ilya Kantor
4133532cd8
minor fixes
2020-08-04 10:29:19 +03:00
Ilya Kantor
0f7443b5df
minor fixes
2020-08-04 09:25:45 +03:00
Chao Zhang
9e3065f6ae
Fix a comment
2020-07-09 15:48:36 -04:00
Ilya Kantor
a9925f4917
minor fixes
2020-06-15 14:54:44 +03:00
LeviDing
9c2cb1bf02
Fix minor typo error
2020-05-01 11:39:53 +08:00
Ilya Kantor
40847464c1
Merge pull request #1799 from leviding/patch-5
...
Fix error in 1-js/11-async/05-promise-api/article.md
2020-03-21 21:14:32 +03:00
Etheraex
b93cf9d4fe
Minor statement change
2020-03-14 20:59:49 +01:00
LeviDing
07bd7249fe
Update article.md
2020-03-13 16:02:22 +08:00
Yury Nekhaevskiy
1304aa12fc
Remove unnecessary return in couple of examples
2020-02-14 10:34:33 +03:00
Peter Roche
837f7ab024
Update article.md
...
"chapter" -> "article" 2x
2020-02-11 22:19:54 -07:00
Peter Roche
9927cd09de
Update article.md
...
Maybe clarifying a bit where `.json()` comes from. I personally found it a bit confusing at first.
2020-02-03 20:23:05 -07:00
Peter Roche
4b124fb7df
Update article.md
...
"allows to use" -> "allows us to use"
"to use with await" -> "to use it with await"
2020-02-02 22:47:11 -07:00
Violet Bora Lee
6f7ec12358
minor fixes
2020-02-02 03:25:04 +09:00
Peter Roche
58205b3dfd
Update article.md
...
"continues to closest" -> "continues to next closest". Consistent w/ usage in rest of explanation.
2020-01-29 00:07:49 -07:00
Peter Roche
c8b717e936
Update article.md
...
Change "occasional" to "accidental". I think that's what you mean, and the words are not synonymous in English.
2020-01-28 23:59:24 -07:00
Violet Bora Lee
e85e48f8d0
minor fixes
2020-01-27 15:24:23 +09:00
Peter Roche
cae000f4ee
Update article.md
...
Small punctuation change.
Separately, I didn't change anything on this today, but note that line 34 above:
"So to summarize: the executor runs automatically and attempts to perform a job. When it is finished with the attempt it calls `resolve` if it was successful or `reject` if there was an error."
was, before it was changed recently, pretty much the same as line 82 above:
"To summarize, the executor should perform a job (usually something that takes time) and then call `resolve` or `reject` to change the state of the corresponding promise object."
So maybe some revision there is in order -- to not have both, or to change one or both. Not familiar enough with the article at this point to make the revision.
2020-01-22 23:08:01 -07:00
Peter Roche
f186b7c86f
Update article.md
...
Removed extraneous quote mark I had accidentally inserted.
2020-01-21 23:20:32 -07:00
Peter Roche
5ea9b55670
Update article.md
...
As threatened, change line 34, "to summarize: ..."
Also add "these" before "internal properties".
2020-01-21 23:15:18 -07:00
Ilya Kantor
b9bb854c73
Merge branch 'master' into patch-2
2020-01-19 16:26:35 +01:00
Peter Roche
492b6e18e7
Update article.md
...
Actually taking out a comma.
2020-01-18 21:41:11 -07:00
Jonathan Chue
642c70153b
Merge branch 'master' into patch-7
2020-01-02 13:46:32 -08:00
Jonathan Chue
3f1812ab11
Update as per @paroche's comments
2020-01-02 13:45:39 -08:00
Peter Roche
14e4e9f96b
Merge pull request #1666 from jchue/patch-8
...
Make minor grammar corrections/updates to async/async-await
2020-01-02 14:41:24 -07:00
Peter Roche
a09d162fe4
Merge pull request #1661 from jchue/patch-3
...
Make minor grammar corrections/updates to async/promise-chaining
2020-01-02 14:23:09 -07:00
Jonathan Chue
0cf57ca7f2
Updated as per @paroche's comments
2020-01-02 12:52:57 -08:00
