Commit graph

393 commits

Author SHA1 Message Date
Ilya Kantor
601d9583f7
Merge pull request #1530 from lumosmind/patch-5
add parameter definition to arr.find()
2019-10-29 23:43:23 +03:00
Ilya Kantor
be6856d4bc closes #1532 2019-10-29 23:42:40 +03:00
Ilya Kantor
726f2a8385
Merge pull request #1535 from lumosmind/patch-7
Array type variables also support values() method
2019-10-29 23:40:33 +03:00
Ilya Kantor
2964aa0d00
Merge pull request #1542 from lumosmind/patch-11
coding style conflict with the tutorial itself
2019-10-29 23:38:09 +03:00
lumosmind
b32ce2c9a0
coding style conflict with the tutorial itself
variable user is using for both string and object type different values. these situation is called "ninja code" bu author :)

"Add a new variable only when absolutely necessary.
Instead, reuse existing names. Just write new values into them."
https://javascript.info/ninja-code
2019-10-29 15:36:57 +03:00
lumosmind
9fb20768b0
correction for code template consistency
':' character is indicating 'var2' is a key of object.
2019-10-29 10:00:59 +03:00
lumosmind
634531a843
Array type variables also supports values()
arr.values() is supported by majority of browsers. So, maybe we need to change the exception in article.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/values
2019-10-28 23:07:49 +03:00
lumosmind
07a21c814f
add attribute defination to arr.find()
For consistency with definition of "arr.filter(fn)" , we need to add 'fn' parameter to definition of arr.find().
2019-10-28 17:21:26 +03:00
Alexey Pyltsyn
4159a65ea2
'str' inside of 'start' (#1529)
'str' inside of 'start'
2019-10-28 17:03:38 +03:00
lumosmind
b5725a8be0
'str' inside of 'start'
splice method's minimum parameter is 'start' and it is number type. In this tutorial 'str' stands for string parameters.
2019-10-28 16:27:55 +03:00
lumosmind
e70f039a59
string outputs without quotes
Some of string outputs are represented with quotes but some of not, there is a 	inconsistency.
2019-10-28 12:04:12 +03:00
Alexey Pyltsyn
33cca1b111
Fix confusion in the task 2019-10-22 18:51:47 +03:00
paroche
f38d8c921c
Update task.md
As I said, insert "about" before "whether"
2019-10-16 00:00:12 -06:00
Ilya Kantor
13ca92d478
Merge pull request #1456 from hrodward/patch-1
Update task.md
2019-10-15 22:26:26 +03:00
hrodward
6da81c5e1f
Update task.md
Fixed minor grammatical errors
2019-10-15 10:30:28 +02:00
hrodward
816b29f78a
Update task.md
Fixed grammatical errors
2019-10-14 12:26:44 +02:00
Ilya Kantor
5fe6977c74
Merge pull request #1453 from Violet-Bora-Lee/patch-41
Update solution.md
2019-10-14 09:27:30 +03:00
Violet.Lee
effb5b9308
minor 2019-10-14 03:22:02 +09:00
Violet.Lee
fb96a7624d
Update solution.md 2019-10-14 00:23:03 +09:00
Ilya Kantor
6d44c1e1ac fixes 2019-10-10 17:29:27 +03:00
Ilya Kantor
7418213b66 re-import images from Sketch (no changes) 2019-10-10 17:08:16 +03:00
Ilya Kantor
c8a11f3e86 minor 2019-10-02 10:36:06 +03:00
Ilya Kantor
45075277b1 closes #1399 2019-10-02 10:12:47 +03:00
Ilya Kantor
12ef7fc704
Update article.md 2019-09-28 19:41:22 +03:00
Ilya Kantor
bee6d79ca4 minor 2019-09-27 08:42:15 +03:00
va-z
8f0476079c
Typo fixes 2019-09-23 20:27:14 +05:00
Ilya Kantor
a0720187cb fixes 2019-09-07 17:39:32 +03:00
Ilya Kantor
c738e37b01 fixes 2019-09-07 17:30:55 +03:00
Ilya Kantor
cdc480a577 minor 2019-09-06 20:14:00 +03:00
Ilya Kantor
9869922dbf Merge branch 'regexp2' 2019-09-06 16:57:40 +03:00
Ilya Kantor
4232a53219 WIP 2019-09-06 16:48:59 +03:00
Scott Martin
01c531b375
Update MDN docs link for tagged templates 2019-09-03 17:49:23 +01:00
Ilya Kantor
ef370b6ace closes #1220 2019-09-03 14:55:10 +03:00
Douglas Mariano Valero
e3cec3b488
Fixed a typo 2019-09-01 13:16:04 -03:00
Douglas Mariano Valero
7556bda13a
Typo 2019-09-01 01:06:11 -03:00
Ilya Kantor
b0d39f8568
Merge pull request #1292 from Violet-Bora-Lee/patch-26
minor
2019-08-30 23:05:40 +03:00
Violet.Lee
bfeb7a4baa
typo 2019-08-31 03:31:19 +09:00
Violet.Lee
6fc41bac7a
minor 2019-08-30 05:35:48 +09:00
Ilya Kantor
95597b8fda
Merge pull request #1289 from Raggan/Raggan-patch-1
Fixed spelling error
2019-08-29 22:06:05 +03:00
Ilya Kantor
df3260a44e fixes 2019-08-29 20:40:41 +03:00
Simon Holdorf
8b5693dbfe
Fixed spelling error
So here JavaScript assumes that we have a code block, but why there's an error. --> Makes no sense so replaced "but" with "that's"
2019-08-28 21:54:27 +02:00
Ilya Kantor
5c8d24a582 closes #1271 2019-08-27 08:20:18 +03:00
Ilya Kantor
192c4115fa
Merge pull request #1258 from atimidguy/atimidguy-patch-1
Update article.md
2019-08-21 10:21:00 +03:00
atimidguy
05368cea2b
Update article.md
fixed typo 'stringss' in 1-js/05-data-types/05-array-methods/article.md
2019-08-21 14:55:46 +08:00
Pascal BOURUT
2ad0ff194b
Third argument from JSON.stringify is "space".
Argument "space" was spelt "spacer" or "spaces" in the article.
2019-08-20 15:21:31 -07:00
Vim Shah
107fed11a7
Update article.md
Quick typo fix
2019-08-19 16:42:15 -07:00
Ilya Kantor
d94b2922dc fixes 2019-08-17 12:49:03 +03:00
Jose E. Pimentel
4856c06dee
Replace "Midget" with "Widget" in example words
Word "Midget" can be offensive and shouldn't be included as an example in educational materials. Replaced with "Widget" for better consistency/inclusiveness. https://www.lpaonline.org/the-m-word
2019-08-13 09:54:35 -04:00
Ilya Kantor
9bfc8cfa9c minor 2019-08-11 14:24:31 +03:00
Ilya Kantor
4d44df6a3a Embed font to SVG 2019-08-11 14:17:38 +03:00