Ilya Kantor
7907cd667c
minor fixes
2020-08-04 10:33:40 +03:00
Ilya Kantor
f0ad0bafa2
minor fixes
2020-08-04 10:30:25 +03:00
Ilya Kantor
fb4dda68e5
minor fixes
2020-08-04 10:30:13 +03:00
Ilya Kantor
d2f7d14288
minor fixes
2020-08-04 10:29:38 +03:00
Ilya Kantor
0e592a95c7
minor fixes
2020-08-04 10:29:29 +03:00
Ilya Kantor
4133532cd8
minor fixes
2020-08-04 10:29:19 +03:00
Ilya Kantor
0f7443b5df
minor fixes
2020-08-04 09:25:45 +03:00
Chao Zhang
9e3065f6ae
Fix a comment
2020-07-09 15:48:36 -04:00
Ilya Kantor
a9925f4917
minor fixes
2020-06-15 14:54:44 +03:00
LeviDing
9c2cb1bf02
Fix minor typo error
2020-05-01 11:39:53 +08:00
Ilya Kantor
40847464c1
Merge pull request #1799 from leviding/patch-5
...
Fix error in 1-js/11-async/05-promise-api/article.md
2020-03-21 21:14:32 +03:00
Etheraex
b93cf9d4fe
Minor statement change
2020-03-14 20:59:49 +01:00
LeviDing
07bd7249fe
Update article.md
2020-03-13 16:02:22 +08:00
Yury Nekhaevskiy
1304aa12fc
Remove unnecessary return in couple of examples
2020-02-14 10:34:33 +03:00
Peter Roche
837f7ab024
Update article.md
...
"chapter" -> "article" 2x
2020-02-11 22:19:54 -07:00
Peter Roche
9927cd09de
Update article.md
...
Maybe clarifying a bit where `.json()` comes from. I personally found it a bit confusing at first.
2020-02-03 20:23:05 -07:00
Peter Roche
4b124fb7df
Update article.md
...
"allows to use" -> "allows us to use"
"to use with await" -> "to use it with await"
2020-02-02 22:47:11 -07:00
Violet Bora Lee
6f7ec12358
minor fixes
2020-02-02 03:25:04 +09:00
Peter Roche
58205b3dfd
Update article.md
...
"continues to closest" -> "continues to next closest". Consistent w/ usage in rest of explanation.
2020-01-29 00:07:49 -07:00
Peter Roche
c8b717e936
Update article.md
...
Change "occasional" to "accidental". I think that's what you mean, and the words are not synonymous in English.
2020-01-28 23:59:24 -07:00
Violet Bora Lee
e85e48f8d0
minor fixes
2020-01-27 15:24:23 +09:00
Peter Roche
cae000f4ee
Update article.md
...
Small punctuation change.
Separately, I didn't change anything on this today, but note that line 34 above:
"So to summarize: the executor runs automatically and attempts to perform a job. When it is finished with the attempt it calls `resolve` if it was successful or `reject` if there was an error."
was, before it was changed recently, pretty much the same as line 82 above:
"To summarize, the executor should perform a job (usually something that takes time) and then call `resolve` or `reject` to change the state of the corresponding promise object."
So maybe some revision there is in order -- to not have both, or to change one or both. Not familiar enough with the article at this point to make the revision.
2020-01-22 23:08:01 -07:00
Peter Roche
f186b7c86f
Update article.md
...
Removed extraneous quote mark I had accidentally inserted.
2020-01-21 23:20:32 -07:00
Peter Roche
5ea9b55670
Update article.md
...
As threatened, change line 34, "to summarize: ..."
Also add "these" before "internal properties".
2020-01-21 23:15:18 -07:00
Ilya Kantor
b9bb854c73
Merge branch 'master' into patch-2
2020-01-19 16:26:35 +01:00
Peter Roche
492b6e18e7
Update article.md
...
Actually taking out a comma.
2020-01-18 21:41:11 -07:00
Jonathan Chue
642c70153b
Merge branch 'master' into patch-7
2020-01-02 13:46:32 -08:00
Jonathan Chue
3f1812ab11
Update as per @paroche's comments
2020-01-02 13:45:39 -08:00
Peter Roche
14e4e9f96b
Merge pull request #1666 from jchue/patch-8
...
Make minor grammar corrections/updates to async/async-await
2020-01-02 14:41:24 -07:00
Peter Roche
a09d162fe4
Merge pull request #1661 from jchue/patch-3
...
Make minor grammar corrections/updates to async/promise-chaining
2020-01-02 14:23:09 -07:00
Jonathan Chue
0cf57ca7f2
Updated as per @paroche's comments
2020-01-02 12:52:57 -08:00
Jonathan Chue
6495b155f3
Update as per @paroche's comments
2020-01-02 12:44:48 -08:00
Jonathan Chue
95ddbe45a7
Update as per @paroche's comments
2020-01-02 12:41:00 -08:00
Jonathan Chue
48261eb97e
Update as per @paroche's comments
2020-01-02 12:36:56 -08:00
Alexey Pyltsyn
28ed5a3f7d
Merge pull request #1697 from jianlin/patch-1
...
fix typo
2019-12-29 19:17:02 +03:00
Peter Roche
6be43b16a9
Merge pull request #1664 from jchue/patch-6
...
Make minor grammar corrections/updates to async/promisify
2019-12-27 16:42:33 -07:00
jianlin
e3a2051c0e
fix typo
2019-12-27 05:25:15 -08:00
Ilya Kantor
7002488bb5
Merge pull request #1663 from jchue/patch-5
...
Make minor grammar corrections/updates to async/promise-api
2019-12-27 16:11:50 +03:00
Ilya Kantor
94c6f0bbd3
Merge pull request #1662 from jchue/patch-4
...
Make minor grammar corrections/updates to async/promise-error-handling
2019-12-27 16:03:31 +03:00
Ilya Kantor
9236ab3737
Merge pull request #1690 from KennethKinLum/patch-4
...
fix run-on sentence
2019-12-27 16:03:06 +03:00
Ilya Kantor
0716a85fab
Merge pull request #1688 from KennethKinLum/patch-1
...
fixes
2019-12-27 09:21:08 +03:00
Ilya Kantor
461ea30b8c
closes #1689
2019-12-27 09:20:09 +03:00
Kin Lum
3591df7b11
fix run-on sentence
2019-12-26 10:33:44 -08:00
Kin Lum
ac666dec00
fiexes
2019-12-26 09:11:11 -08:00
Jonathan Chue
bca0359578
Make minor grammar corrections/updates to async/async-await
2019-12-07 16:54:14 -08:00
Jonathan Chue
38f0468910
Make minor grammar corrections/updates to async/microtask-queue
2019-12-07 16:52:44 -08:00
Jonathan Chue
58398a6586
Make minor grammar corrections/updates to async/promisify
2019-12-07 16:51:01 -08:00
Jonathan Chue
a53fb38c49
Make minor grammar corrections/updates to async/promise-api
2019-12-07 16:49:18 -08:00
Jonathan Chue
375630bbd2
Make minor grammar corrections/updates to async/promise-error-handling
2019-12-07 16:46:14 -08:00
Jonathan Chue
07ae558025
Make minor grammar corrections/updates to async/promise-chaining
2019-12-07 16:43:10 -08:00
