Commit graph

35 commits

Author SHA1 Message Date
Ilya Kantor
e9686467e6 minor fixes, close #2137 2020-09-24 11:55:34 +03:00
Peter Roche
cae000f4ee
Update article.md
Small punctuation change. 

Separately, I didn't change anything on this today, but note that line 34 above:
"So to summarize: the executor runs automatically and attempts to perform a job. When it is finished with the attempt it calls `resolve` if it was successful or `reject` if there was an error."
was, before it was changed recently, pretty much the same as line 82 above:
"To summarize, the executor should perform a job (usually something that takes time) and then call `resolve` or `reject` to change the state of the corresponding promise object."
So maybe some revision there is in order -- to not have both, or to change one or both. Not familiar enough with the article at this point to make the revision.
2020-01-22 23:08:01 -07:00
Peter Roche
f186b7c86f
Update article.md
Removed extraneous quote mark I had accidentally inserted.
2020-01-21 23:20:32 -07:00
Peter Roche
5ea9b55670
Update article.md
As threatened, change line 34, "to summarize: ..." 

Also add "these" before "internal properties".
2020-01-21 23:15:18 -07:00
Ilya Kantor
b9bb854c73
Merge branch 'master' into patch-2 2020-01-19 16:26:35 +01:00
Jonathan Chue
48261eb97e
Update as per @paroche's comments 2020-01-02 12:36:56 -08:00
Ilya Kantor
0716a85fab
Merge pull request #1688 from KennethKinLum/patch-1
fixes
2019-12-27 09:21:08 +03:00
Ilya Kantor
461ea30b8c closes #1689 2019-12-27 09:20:09 +03:00
Kin Lum
ac666dec00
fiexes 2019-12-26 09:11:11 -08:00
Jonathan Chue
4c650b54b7 Make minor grammar corrections/updates to async/promise-basics 2019-12-07 16:40:31 -08:00
Artur Haurylkevich
fd70f751e4
add consistency
quick description:
before: .catch(f) is the same as promise.then(null, f)
after: .catch(f) is the same as .then(null, f)
2019-11-18 11:15:01 +03:00
hrodward
6a9bfe185e
Update article.md
Grammar suggestions
2019-10-28 09:31:19 +01:00
Ilya Kantor
c3ef6c07eb fix 2019-09-21 22:29:38 +03:00
Ilya Kantor
427fbea180 minor 2019-09-02 21:58:57 +03:00
Ilya Kantor
89ff13f26d minor 2019-09-02 21:55:37 +03:00
Ilya Kantor
07319c719c minor 2019-09-02 21:50:44 +03:00
Ilya Kantor
93316a428c minor 2019-09-02 21:49:32 +03:00
Ilya Kantor
2f9221f4d3 minor 2019-09-02 21:48:45 +03:00
Ilya Kantor
c6b8c2595d minor 2019-09-02 21:30:08 +03:00
Ilya Kantor
53e5139578 minor 2019-09-02 21:29:28 +03:00
Ilya Kantor
8bd8e90488 minor 2019-08-07 17:31:14 +03:00
Ilya Kantor
e80667391f minor 2019-08-07 11:44:39 +03:00
Ilya Kantor
3ba28aa104 images to svg 2019-07-28 15:42:37 +03:00
K-Sato
2638784a1e
Fix grammer
https://www.grammarly.com/blog/anymore-vs-any-more/
2019-06-17 10:41:59 +09:00
Ilya Kantor
2009009f1f minor 2019-06-05 14:45:50 +03:00
Ilya Kantor
0873473402 minor 2019-05-29 21:39:02 +03:00
Enrico Palmieri
b457de1e12 Replace error string with template strings 2019-05-01 21:27:21 +02:00
Alexey Pyltsyn
feebafcc9e Fix typos 2019-05-01 16:51:27 +03:00
Alaa Bouayed
8ef9fd28dc
Clarity 2019-04-22 16:23:57 +01:00
Ilya Kantor
67ed0e01c8
Merge pull request #895 from holub008/master
Mismatched example code and image in promise basics
2019-04-09 23:37:56 +03:00
Eli Geller
16deb3c6c1 General grammar/typo changes 2019-04-09 13:28:55 -04:00
Karl Holub
798840ee0d
promise result exact string match 2019-04-08 10:34:46 -05:00
vasilevx
cae79b54e5
Fix function parameter
As in example above
2019-03-29 05:01:56 +03:00
Ilya Kantor
16cfa3037b add promise queue 2019-03-06 23:27:31 +03:00
Ilya Kantor
1373f6158c refactor classes, add private, minor fixes 2019-03-05 18:44:28 +03:00
Renamed from 1-js/09-async/02-promise-basics/article.md (Browse further)