Essays#getEssays(List<User>) reuses single AsyncHttpClient instance and closes it
This commit is contained in:
parent
effb94805f
commit
ca07c8a35c
1 changed files with 30 additions and 20 deletions
|
@ -1,10 +1,11 @@
|
|||
package com.moandjiezana.tent.essayist;
|
||||
|
||||
import com.google.common.base.Throwables;
|
||||
import com.moandjiezana.tent.client.TentClient;
|
||||
import com.moandjiezana.tent.client.TentClientAsync;
|
||||
import com.moandjiezana.tent.client.posts.Post;
|
||||
import com.moandjiezana.tent.client.posts.PostQuery;
|
||||
import com.ning.http.client.AsyncHttpClient;
|
||||
import com.ning.http.client.providers.jdk.JDKAsyncHttpProvider;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.Collections;
|
||||
|
@ -14,23 +15,29 @@ import java.util.List;
|
|||
import java.util.concurrent.CopyOnWriteArrayList;
|
||||
import java.util.concurrent.Future;
|
||||
|
||||
import org.slf4j.Logger;
|
||||
import org.slf4j.LoggerFactory;
|
||||
|
||||
public class Essays {
|
||||
|
||||
public List<Post> getEssays(List<User> users, TentClient tentClient) {
|
||||
private static final Logger LOGGER = LoggerFactory.getLogger(Essays.class);
|
||||
|
||||
public List<Post> getEssays(List<User> users) {
|
||||
CopyOnWriteArrayList<Future<List<Post>>> futurePosts = new CopyOnWriteArrayList<Future<List<Post>>>();
|
||||
|
||||
AsyncHttpClient httpClient = new AsyncHttpClient(new JDKAsyncHttpProvider(TentClientAsync.getDefaultAsyncHttpClientConfigBuilder().build()));
|
||||
|
||||
try {
|
||||
for (User user : users) {
|
||||
futurePosts.add(new TentClientAsync(user.getProfile()).getPosts(new PostQuery().entity(user.getProfile().getCore().getEntity()).postTypes(Post.Types.essay("v0.1.0"))));
|
||||
futurePosts.add(new TentClientAsync(user.getProfile(), httpClient).getPosts(new PostQuery().entity(user.getProfile().getCore().getEntity()).postTypes(Post.Types.essay("v0.1.0"))));
|
||||
}
|
||||
|
||||
List<Post> posts = new ArrayList<Post>(futurePosts.size());
|
||||
for (Future<List<Post>> postFuture : futurePosts) {
|
||||
for (Future<List<Post>> futurePost : futurePosts) {
|
||||
try {
|
||||
posts.addAll(postFuture.get());
|
||||
posts.addAll(futurePost.get());
|
||||
} catch (Exception e) {
|
||||
LoggerFactory.getLogger(Essays.class).error("Could not load Post", Throwables.getRootCause(e));
|
||||
LOGGER.error("Could not load Post", Throwables.getRootCause(e));
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -42,5 +49,8 @@ public class Essays {
|
|||
});
|
||||
|
||||
return posts;
|
||||
} finally {
|
||||
httpClient.close();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue