jeena/home-assistant
1
0
Fork 0
Code Issues Pull requests Projects Packages Wiki Activity Actions
home-assistant/tests
History
Bas Nijholt c59bf0bff6 genericpath is an internal Python module and shouldn't be imported according to core Python devs. (see [this](https://bugs.python.org/msg358136) comment) (#29903) 
For a reason unknown to me, @exxamalte introduced this in https://github.com/home-assistant/home-assistant/pull/14342.

The problem is that Linux and macOS implement `os.path` differently, one imports from [`ntpath.py`](https://github.com/python/cpython/blob/master/Lib/ntpath.py) and the other one from [`posixpath.py`](https://github.com/python/cpython/blob/master/Lib/posixpath.py), and both these files use `genericpath.py`.

Somehow, `isort` on macOS will see `genericpath` as a third party library and sort it accordingly.
Other Unix-based OSes will correctly treat `genericpath` as an internal library.

This problem led to a sorting sequence in the following commits:

- ca0fad2cbb
- f5d4878992
- 7d68e88d31
- 1fee400dcd

This supersedes https://github.com/home-assistant/home-assistant/pull/29893.
2019-12-13 09:47:09 +01:00
..
auth Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
components genericpath is an internal Python module and shouldn't be imported according to core Python devs. (see [this](https://bugs.python.org/msg358136) comment) (#29903) 2019-12-13 09:47:09 +01:00
fixtures Add Elgato Key Light integration (#29592) 2019-12-08 09:26:31 +01:00
helpers Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
mock Black 2019-07-31 12:25:30 -07:00
resources Revised package util tests 2016-01-30 14:08:32 -05:00
scripts Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
test_util Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
testing_config Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
util Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
__init__.py async HTTP component (#3914) 2016-10-23 23:48:01 -07:00
bandit.yaml Add bandit, use to catch known vulnerable XML parsing (#28341) 2019-11-18 09:10:15 +01:00
common.py Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
conftest.py Remove uvloop event policy (#29835) 2019-12-11 13:28:50 +01:00
test_bootstrap.py Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
test_config.py Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
test_config_entries.py Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
test_core.py Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
test_data_entry_flow.py Black 2019-07-31 12:25:30 -07:00
test_loader.py Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
test_main.py Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00
test_requirements.py Sort imports for requirements.py and its test using isort (#29836) 2019-12-11 12:12:06 +01:00
test_setup.py Sort imports according to PEP8 for 'tests' (#29791) 2019-12-09 16:52:24 +01:00