Refactor archive helper

Now returns a list in an li instead of full markup
This commit is contained in:
Nic Haynes 2011-12-08 10:48:11 -06:00
parent f3d32c1ac5
commit 7d8588dfd2
6 changed files with 13 additions and 17 deletions

View file

@ -2,9 +2,7 @@ module BlogPostsHelper
def blog_archive_list
posts = BlogPost.live.select('published_at').all_previous
return nil if posts.blank?
html = '<section id="blog_archive_list"><h2>'
html << t('archives', :scope => 'blog.shared')
html << '</h2><nav><ul>'
html = ''
links = []
super_old_links = []
@ -34,7 +32,6 @@ module BlogPostsHelper
html << link_to(text, archive_blog_posts_path(:year => year))
html << "</li>"
end
html << '</ul></nav></section>'
html.html_safe
end

View file

@ -13,7 +13,7 @@
<%= render :partial => "/blog/shared/categories" %>
<%= render :partial => "/blog/shared/tags" %>
<%= render :partial => "/blog/shared/rss_feed" %>
<%= blog_archive_list %>
<%= render :partial => "/blog/shared/archive_list" %>
<% end %>
<%= render :partial => "/shared/content_page" %>

View file

@ -17,7 +17,7 @@
<%= render :partial => "/blog/shared/categories" %>
<%= render :partial => "/blog/shared/tags" %>
<%= render :partial => "/blog/shared/rss_feed" %>
<%= blog_archive_list %>
<%= render :partial => "/blog/shared/archive_list" %>
<% end %>
<%= render :partial => "/shared/content_page" %>

View file

@ -15,7 +15,7 @@
<%= render :partial => "/blog/shared/categories" %>
<%= render :partial => "/blog/shared/tags" %>
<%= render :partial => "/blog/shared/rss_feed" %>
<%= blog_archive_list %>
<%= render :partial => "/blog/shared/archive_list" %>
<% end %>
<%= render :partial => "/shared/content_page" %>

View file

@ -0,0 +1,9 @@
<%
archive_posts = blog_archive_list
%>
<% if archive_posts.any? %>
<h2><%= t('archives', :scope => 'blog.shared') %></h2>
<ul>
<%= archive_posts %>
</ul>
<% end %>

View file

@ -1,10 +0,0 @@
<% if @blog_posts.many? %>
<h2><%= t('.other') %></h2>
<ul id="blog_posts">
<% @blog_posts.each do |blog_post| %>
<li class='clearfix'>
<%= link_to blog_post.title, blog_post_url(blog_post) %>
</li>
<% end %>
</ul>
<% end %>