jeena/telldus
1
0
Fork 0
Code Issues Pull requests Projects Packages Wiki Activity Actions

Temporarily suppress cpplint errors "runtime/printf" for sscanf(). We should prpbably remove them later

Browse source
This commit is contained in:
Micke Prag 2012-06-19 16:23:36 +02:00
parent 58bf51a6e8
commit dbb11602ec
5 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
telldus-core/service/ProtocolEverflourish.cpp
View file

@ -101,7 +101,8 @@ std::string ProtocolEverflourish::decodeData(const ControllerMessage &dataMsg) {
unsigned int unit = 0;
unsigned int method = 0;
sscanf(data.c_str(), "%X", &allData);
// TODO(micke): Convert sscanf. This is slow and can overflow buffers!
sscanf(data.c_str(), "%X", &allData); // NOLINT(runtime/printf)
house = allData & 0xFFFC00;
house >>= 10;

3
telldus-core/service/ProtocolNexa.cpp
View file

@ -167,7 +167,8 @@ std::string ProtocolNexa::getStringSelflearningForCode(int intHouse, int intCode
std::string ProtocolNexa::decodeData(const ControllerMessage& dataMsg) {
uint32_t allData = 0;
sscanf(dataMsg.getParameter("data").c_str(), "%lx", reinterpret_cast<long*>(&allData)); // NOLINT(runtime/int)
// TODO(micke): Convert sscanf. This is slow and can overflow buffers!
sscanf(dataMsg.getParameter("data").c_str(), "%lx", reinterpret_cast<long*>(&allData)); // NOLINT
if(TelldusCore::comparei(dataMsg.model(), L"selflearning")) {
// selflearning

3
telldus-core/service/ProtocolSartano.cpp
View file

@ -50,7 +50,8 @@ std::string ProtocolSartano::decodeData(const ControllerMessage &dataMsg) {
unsigned int method2 = 0;
unsigned int method = 0;
sscanf(data.c_str(), "%X", &allDataIn);
// TODO(micke): Convert sscanf. This is slow and can overflow buffers!
sscanf(data.c_str(), "%X", &allDataIn); // NOLINT(runtime/printf)
uint16_t mask = (1<<11);
for(int i = 0; i < 12; ++i) {

3
telldus-core/service/ProtocolWaveman.cpp
View file

@ -30,7 +30,8 @@ std::string ProtocolWaveman::decodeData(const ControllerMessage& dataMsg) {
unsigned int unit = 0;
unsigned int method = 0;
sscanf(dataMsg.getParameter("data").c_str(), "%lx", reinterpret_cast<long*>(&allData)); // NOLINT(runtime/int)
// TODO(micke): Convert sscanf. This is slow and can overflow buffers!
sscanf(dataMsg.getParameter("data").c_str(), "%lx", reinterpret_cast<long*>(&allData)); // NOLINT
method = allData & 0xF00;
method >>= 8;

3
telldus-core/service/ProtocolX10.cpp
View file

@ -116,7 +116,8 @@ std::string ProtocolX10::getStringForMethod(int method, unsigned char data, Cont
std::string ProtocolX10::decodeData(const ControllerMessage& dataMsg) {
int intData = 0, currentBit = 31;
bool method = 0;
sscanf(dataMsg.getParameter("data").c_str(), "%X", &intData);
// TODO(micke): Convert sscanf. This is slow and can overflow buffers!
sscanf(dataMsg.getParameter("data").c_str(), "%X", &intData); // NOLINT(runtime/printf)
int unit = 0;
int rawHouse = 0;