jeena/chuck.js
1
0
Fork 0
mirror of https://github.com/logsol/chuck.js.git synced 2026-05-11 10:37:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Makes singleton object variable names of DomController first letter lowercase

Browse source 
When we require a singleton, its instance name should be named
by lowercase, since it is not a class.

Relates to #128
This commit is contained in:
logsol 2016-10-10 21:50:03 +02:00
parent 875a40185e
commit ffc55a204a
7 changed files with 15 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

10
app/Game/Client/Networker.js
View file

@ -7,7 +7,7 @@ define([
"Game/Client/View/DomController"
],
function (ProtocolHelper, GameController, User, Nc, Settings, DomController) {
function (ProtocolHelper, GameController, User, Nc, Settings, domController) {
"use strict";
@ -50,7 +50,7 @@ function (ProtocolHelper, GameController, User, Nc, Settings, DomController) {
Nc.on(Nc.ns.client.to.server.gameCommand.send, this.sendGameCommand, this);
Nc.on(Nc.ns.core.game.events.level.loaded, this.onLevelLoaded, this);
DomController.setNick(nickname);
domController.setNick(nickname);
}
// Socket callbacks
@ -63,7 +63,7 @@ function (ProtocolHelper, GameController, User, Nc, Settings, DomController) {
nickname: this.nickname
}
this.sendCommand('join', options);
DomController.setConnected(true);
domController.setConnected(true);
} else {
alert("Error: no channel name");
window.location.href = "/";
@ -74,7 +74,7 @@ function (ProtocolHelper, GameController, User, Nc, Settings, DomController) {
//if(this.gameController) this.gameController.destruct();
//this.gameController = null;
console.log('disconnected. game destroyed. no auto-reconnect');
DomController.setConnected(false);
domController.setConnected(false);
}
Networker.prototype.onJoinSuccess = function (options) {
@ -183,7 +183,7 @@ function (ProtocolHelper, GameController, User, Nc, Settings, DomController) {
Networker.prototype.onPong = function(timestamp) {
var ping = (Date.now() - parseInt(timestamp, 10));
DomController.setPing(ping);
domController.setPing(ping);
setTimeout(this.ping.bind(this), 1000);
};