Commit graph

4529 commits

Author SHA1 Message Date
LeviDing
356d5278cd
Fix minor typo error: change when when to when 2020-07-18 15:38:36 +08:00
Peter Roche
72482bc435
Update article.md
Revision to unary plus not allowed bigints description in response to PR
2020-07-16 10:20:25 -06:00
Ilya Kantor
c3a11c85e5
Merge pull request #2004 from leviding/patch-16
Change equality sign `=` to equality sign `==`
2020-07-12 16:21:12 +03:00
Ilya Kantor
1f0fcb7de6 minor fixes 2020-07-12 16:20:39 +03:00
Ilya Kantor
9e59ec101f
Merge pull request #2005 from leviding/patch-17
Fix some confusing expression in chapter of optional chaining
2020-07-12 16:04:04 +03:00
LeviDing
450612a09e
Fix some confusing expression 2020-07-12 18:45:38 +08:00
LeviDing
abfa6dc1fe
Change equality sign = to equality sign == 2020-07-12 18:33:50 +08:00
Ilya Kantor
445bda3980 minor fixes 2020-07-05 15:52:10 +03:00
Ilya Kantor
0edc6518de minor fixes 2020-07-05 12:45:21 +03:00
Ilya Kantor
26bf51af3e minor fixes 2020-07-02 14:26:08 +03:00
Ilya Kantor
94c8fcb248 minor fixes 2020-07-02 14:24:52 +03:00
Ilya Kantor
ea3d179622
Merge pull request #1981 from leviding/patch-13
Fix minor typo error: delete blank
2020-07-01 11:57:51 +03:00
Ilya Kantor
da9849d61a fixes #1979 2020-07-01 11:54:48 +03:00
LeviDing
db102cbf89
Fix minor typo error: delete blank 2020-07-01 16:18:46 +08:00
Ilya Kantor
340ce43421 minor fixes 2020-06-27 21:54:32 +03:00
Ilya Kantor
b3fbb9c9f4 minor fixes 2020-06-27 12:57:42 +03:00
Ilya Kantor
7b42ecceee minor fixes 2020-06-27 12:56:32 +03:00
Ilya Kantor
ef2760eb86 minor fixes 2020-06-22 19:41:24 +03:00
Ilya Kantor
dde5fed4bd minor fixes 2020-06-22 19:41:24 +03:00
Peter Roche
e4e6a50b57
'where finds it and changes' -> 'where it finds and changes it'
Was tempted to suggest something a bit wordier: "where it finds it and, in this case, changes it", but I thought this would do.
2020-06-21 03:51:06 -06:00
Peter Roche
1f7b137e64
'since this moment' -> 'from this point forward' 2020-06-21 03:26:05 -06:00
Ilya Kantor
c75f66a895
Merge pull request #1967 from joachimklug/issue/#1966
Correct misspelling retarteted -> retargeted
2020-06-21 10:08:51 +03:00
Joachim Klug
a45788bb26
Correct misspelling retarteted -> retargeted
Fixes javascript-tutorial/en.javascript.info#1966
2020-06-21 08:37:25 +02:00
Ilya Kantor
2f80cb7eb0
Merge pull request #1964 from rizkyzhang/patch-4
Fix typo
2020-06-20 09:12:52 +03:00
Rizky
15d638e8d9
Fix typo
followed -> followed by
2020-06-20 03:34:45 +00:00
Ilya Kantor
531864a3a8
Merge pull request #1957 from chanjsq/patch-1
Add bottom and right properties for getCoords()
2020-06-16 19:42:07 +03:00
Ilya Kantor
f1da3ee136
Merge pull request #1962 from aadijoshi/patch-1
Set fake timers before calling throttle
2020-06-16 19:37:29 +03:00
aadijoshi
393f1ce33d
Set fake timers after calling throttle
Calling throttle before setting the fake timers will break any implementations that save a timestamp outside the wrapper function.
2020-06-16 18:51:17 +05:30
Ilya Kantor
0ef2dd3ae4
Merge pull request #1956 from Logan-Schelly/testcases/function-object-5
Testcases/function object 5
2020-06-16 09:14:54 +03:00
Logan Schelly
267e825560 Made the test cases easier to read. 2020-06-15 15:13:01 -06:00
Ilya Kantor
2e575af300
Merge pull request #1959 from xehpuk/patch-1
Fixed onupgradeneeded handling
2020-06-15 19:06:27 +03:00
xehpuk
c13f21d65e
Fixed onupgradeneeded handling
`openRequest.result.version` in `onupgradeneeded` is not the current DB version. It is the requested version, equal to `event.newVersion`. `event.oldVersion` contains the current version.
2020-06-15 17:24:39 +02:00
Ilya Kantor
a9925f4917 minor fixes 2020-06-15 14:54:44 +03:00
Ilya Kantor
64b0ff3949
Merge pull request #1958 from LuiGee3471/unicode-property
Fixed Wikipedia link and list markdown
2020-06-15 14:50:31 +03:00
Ilya Kantor
42b0220680 minor fixes 2020-06-15 14:49:46 +03:00
LuiGee3471
d3ef0d544f Fixed Wikipedia link and list markdown 2020-06-15 11:15:53 +09:00
华晨
1358b5e70f
Add bottom and right properties for getCoords()
The `createMessageUnder()` function below needs the `bottom` coordinate, but it doesn't in the result of `getCoords()`.
2020-06-13 15:36:48 +08:00
Logan Schelly
8e861596d7 Merge branch 'master' of https://github.com/javascript-tutorial/en.javascript.info into testcases/function-object-5 2020-06-10 15:40:04 -06:00
Logan Schelly
e5fe4a08bd Got rid of excessive newlines in task/sum-many-brackets sandbox code. 2020-06-10 15:38:18 -06:00
Logan Schelly
f20fb43f70 Add test case/sandbox for 1-js/06-advanced-functions/06-function-object/5-sum-many-brackets
I used the solution and examples already in the article.
I chose to make the test cases use Array.reduce() to compute the sum,
instead of hard-coding the answer myself.
Not sure how good of practice that is.
2020-06-10 15:29:06 -06:00
Ilya Kantor
b52aa942a8 minor fixes 2020-06-09 13:56:25 +03:00
Ilya Kantor
cd9c81cb79
Merge pull request #1947 from dharohar-rathore/master
Grammar and typo fix in pointer events
2020-06-08 11:08:37 +03:00
Ilya Kantor
21115c84fc
Merge pull request #1948 from diegotc86/patch-1
Match the solution with the question on "Type conversions" task
2020-06-08 11:08:14 +03:00
Ilya Kantor
f5a3f379a4 minor fixes 2020-06-08 11:07:46 +03:00
Ilya Kantor
c2c080ed8e minor fixes 2020-06-08 11:04:16 +03:00
Ilya Kantor
675861b93b
Merge pull request #1945 from Logan-Schelly/testcases/closure-9
Add test cases for 1-js/06-advanced-functions/03-closure/9-sort-by-field
2020-06-08 11:01:38 +03:00
Ilya Kantor
bba7892523
Merge pull request #1944 from michaelborn/patch-1
Grammar fix: Missing "is" in websocket EN article
2020-06-08 11:00:53 +03:00
Ilya Kantor
344993dd0b
Merge pull request #1941 from GabrieleC/master
fixed wrong formatting
2020-06-08 10:59:44 +03:00
Ilya Kantor
30c9c32cd7 minor fixes 2020-06-08 10:59:06 +03:00
Ilya Kantor
cea9d8c9c2 minor fixes 2020-06-08 10:55:41 +03:00