Ilya Kantor
cedd3ed9ad
closes #1742
2020-02-19 00:02:23 +00:00
Ilya Kantor
233b0bd02b
Merge pull request #1752 from nekhaevskiy/patch-1
...
Remove unnecessary return in couple of examples
2020-02-18 23:52:03 +00:00
Ilya Kantor
323f1552ac
Merge pull request #1754 from rizkyzhang/patch-2
...
Update article.md
2020-02-18 23:51:32 +00:00
Ilya Kantor
1c5b07c3c8
Merge pull request #1755 from rizkyzhang/patch-3
...
Fix typo
2020-02-18 23:51:04 +00:00
Ilya Kantor
2437d3de2a
Merge pull request #1759 from cycduck/wage-gap-fix
...
Gender pay gap noticed in recursion article.md
2020-02-18 23:50:27 +00:00
Ilya Kantor
81def0275e
minor fixes
2020-02-18 23:46:24 +00:00
Kelly K H
642b56329e
edited alice's wage difference, wage is based on the average of her male counterparts and rounded up for easy comprehension.
2020-02-18 13:14:35 -05:00
Rizky
44a6c12654
Fix typo
2020-02-16 11:14:09 +07:00
Rizky
2cd077cca8
Update article.md
2020-02-16 11:04:58 +07:00
Yury Nekhaevskiy
1304aa12fc
Remove unnecessary return in couple of examples
2020-02-14 10:34:33 +03:00
Peter Roche
c6c25c97da
Update article.md
...
"if arguments count" -> "if the arguments count"
"allows to easily" -> "allows us to easily"
"seen in the logging example:" -> "seen in the logging example,"
rephrasing rest of above sentence for readability
2020-02-13 22:19:17 -07:00
Peter Roche
7fb11bd13a
Update article.md
...
"get in details" -> "get in to the details"
2020-02-13 21:49:19 -07:00
u-n-known
f8e2ed0eca
Either quotation marks or italicization
...
Highlighting twice is unnecessary.
2020-02-14 00:41:09 +01:00
Georgy
2bc6d87804
Fix translation
2020-02-13 00:07:20 -05:00
Ilya Kantor
cb8c12c5c6
Merge pull request #1746 from u-n-known/patch-2
...
Incorrect precedence numbers (prob. "language-wide")
2020-02-12 12:38:14 +00:00
Peter Roche
837f7ab024
Update article.md
...
"chapter" -> "article" 2x
2020-02-11 22:19:54 -07:00
u-n-known
00a1f2c470
False precedence numbers
...
According to the MDN precedence-table you've linked some precedence numbers are incorrect. Having a quick look at different language versions (French and Russian) this error may has to be corrected at every version.
2020-02-11 18:15:36 +01:00
Alexey Pyltsyn
425a0af8be
Merge pull request #1745 from u-n-known/patch-1
...
Grammar mistake (?)
2020-02-11 14:35:22 +03:00
Peter Roche
0b2e5e745b
Update article.md
...
"on the paper" -> "on paper"
2020-02-10 23:24:00 -07:00
Peter Roche
59861ad2e3
Update article.md
...
"return `undefined`" -> "returns `undefined`"
2020-02-10 23:02:31 -07:00
Peter Roche
bad9ca5465
Update article.md
...
add semicolon at end -> " return prop >= target.start && prop <= target.end;"
2020-02-10 21:45:12 -07:00
u-n-known
bad780799f
Grammar mistake (?)
...
It literally says «Operating System system functions.»
2020-02-10 23:25:43 +01:00
Alexey Pyltsyn
cad5a28a21
Fix link in BigInt
2020-02-10 18:29:17 +03:00
Peter Roche
10c7807f49
Update article.md
...
"as `Proxy` trap" -> "as the `Proxy` trap"
2020-02-08 21:02:22 -07:00
Peter Roche
fd0d378f0a
Update article.md
...
"chapter" -> "article" (6 times or so)
I believe that is consistent with the agreed-upon terminology.
2020-02-08 20:44:59 -07:00
Peter Roche
2fee345f6e
Update article.md
...
"That's not a function" -> "It's not a function"
2020-02-08 16:39:17 -07:00
Peter Roche
08720f059a
Update article.md
...
"better convenience" -> "more convenience"
2020-02-08 16:05:53 -07:00
Peter Roche
3fc0a5d591
Update article.md
...
"`async` attribute" -> "the `async` attribute"
2020-02-08 00:54:14 -07:00
Peter Roche
3fe2976963
Update article.md
...
"be aware that HTML-page" -> "be aware that the HTML page"
2020-02-07 01:08:07 -07:00
Peter Roche
c3213d38f7
Update article.md
...
"allows to configure" -> "allows us to configure"
2020-02-07 00:37:33 -07:00
Peter Roche
bd0fbf925b
Update article.md
...
"Let's see that on examples." -> "Let's look at them using examples:"
2020-02-07 00:33:12 -07:00
Peter Roche
f47b732265
Update article.md
...
"That's the correct variant:" -> "This is the correct variant:"
2020-02-07 00:27:38 -07:00
Peter Roche
a06341ba80
Update article.md
...
"`import` allows to import functionality.." -> "`import` allows the import of functionality..."
"relative the current file" -> "relative to the current file,"
2020-02-07 00:22:01 -07:00
Peter Roche
ce70814086
Update article.md
...
My proposed change may not be right, but "make a request to URL" was unclear, and it's `fetch` that's used below to make the request. If 'request to URL' has some special meaning and is what you want to say, maybe some rephrasing is in order.
2020-02-06 23:36:04 -07:00
Peter Roche
9a4bc89d6d
Update article.md
...
"such as browsers" -> "like in browsers"
2020-02-06 23:27:22 -07:00
Peter Roche
537c33493a
Update article.md
...
Several punctuation changes, yielding:
"1. We use the browser [fetch](info:fetch) method to download from a remote URL. It allows us to supply authorization and other headers if needed -- here GitHub requires `User-Agent`.
2. The fetch result is parsed as JSON. That's again a `fetch`-specific method.
3. We should get the next page URL from the `Link` header of the response. It has a special format, so we use a regexp for that. The next page URL may look like `https://api.github.com/repositories/93253246/commits?page=2 `. It's generated by GitHub itself.
4. Then we yield all commits received, and when they finish, the next `while(url)` iteration will trigger, making one more request."
2020-02-06 23:21:57 -07:00
Peter Roche
671c4d41ee
Update article.md
...
"returns the result outside" -> "returns the result to the outside"
2020-02-06 22:15:48 -07:00
Peter Roche
4d0ceef055
Update article.md
...
"yield is a two-way road" -> "yield is a two-way street"
"Two way street" is by far the more common and accepted way to say this. If you look up "two-way road" you will typically be redirected to "two-way street".
2020-02-06 21:47:38 -07:00
Peter Roche
6994fc096a
Update article.md
...
", we have an object that is not an array, " -> ", we have an object that is not an array, "
2020-02-05 23:46:52 -07:00
Ilya Kantor
0081fbdfb4
Merge pull request #1737 from javascript-tutorial/paroche-patch-15
...
Update article.md
2020-02-05 10:47:11 +00:00
Ilya Kantor
f9feec2d69
minor fixes
2020-02-04 16:43:35 +00:00
Peter Roche
d1a455080d
Update article.md
...
"We can get loop over values by `for..of`:" -> "We can loop over their values using `for..of`"
2020-02-03 23:37:29 -07:00
Peter Roche
9927cd09de
Update article.md
...
Maybe clarifying a bit where `.json()` comes from. I personally found it a bit confusing at first.
2020-02-03 20:23:05 -07:00
Peter Roche
a193448b31
Update article.md
...
"can use" -> "we can use".
2020-02-03 18:13:12 -07:00
Peter Roche
630b95e057
Update article.md
...
A few syntactic and punctuation changes to 'The “try…catch” syntax' section.
2020-02-03 18:02:55 -07:00
Peter Roche
4b124fb7df
Update article.md
...
"allows to use" -> "allows us to use"
"to use with await" -> "to use it with await"
2020-02-02 22:47:11 -07:00
Violet Bora Lee
6f7ec12358
minor fixes
2020-02-02 03:25:04 +09:00
Peter Roche
58205b3dfd
Update article.md
...
"continues to closest" -> "continues to next closest". Consistent w/ usage in rest of explanation.
2020-01-29 00:07:49 -07:00
Peter Roche
c8b717e936
Update article.md
...
Change "occasional" to "accidental". I think that's what you mean, and the words are not synonymous in English.
2020-01-28 23:59:24 -07:00
Ilya Kantor
bd6052f591
Merge pull request #1715 from baooab/patch-4
...
fix typo
2020-01-28 19:15:26 +01:00
