Violet Bora Lee
e85e48f8d0
minor fixes
2020-01-27 15:24:23 +09:00
Ilya Kantor
ff042a0319
Merge pull request #1717 from zeel/typo/bug-object-fix
...
fix: spell correction to existence
2020-01-24 14:35:40 +01:00
Peter Roche
cae000f4ee
Update article.md
...
Small punctuation change.
Separately, I didn't change anything on this today, but note that line 34 above:
"So to summarize: the executor runs automatically and attempts to perform a job. When it is finished with the attempt it calls `resolve` if it was successful or `reject` if there was an error."
was, before it was changed recently, pretty much the same as line 82 above:
"To summarize, the executor should perform a job (usually something that takes time) and then call `resolve` or `reject` to change the state of the corresponding promise object."
So maybe some revision there is in order -- to not have both, or to change one or both. Not familiar enough with the article at this point to make the revision.
2020-01-22 23:08:01 -07:00
Peter Roche
f186b7c86f
Update article.md
...
Removed extraneous quote mark I had accidentally inserted.
2020-01-21 23:20:32 -07:00
Peter Roche
5ea9b55670
Update article.md
...
As threatened, change line 34, "to summarize: ..."
Also add "these" before "internal properties".
2020-01-21 23:15:18 -07:00
Zeel
4e4144b084
fix: spell correction to existence
2020-01-21 16:16:09 +05:30
zhangbao
3a071c9279
fix typo
2020-01-20 15:34:31 +08:00
Ilya Kantor
7cd8f55be2
minor fixes
2020-01-19 22:30:09 +01:00
Ilya Kantor
6384ccba05
minor fixes
2020-01-19 20:32:27 +01:00
Ilya Kantor
1e475bf1af
Merge pull request #1711 from tarasyyyk/master
...
Change panel names according to official documentation
2020-01-19 18:45:29 +01:00
Ilya Kantor
b9bb854c73
Merge branch 'master' into patch-2
2020-01-19 16:26:35 +01:00
Peter Roche
492b6e18e7
Update article.md
...
Actually taking out a comma.
2020-01-18 21:41:11 -07:00
Ilya Kantor
b2d69c1bd3
Merge pull request #1704 from baooab/patch-3
...
Fix typo
2020-01-18 15:25:41 +01:00
Ilya Kantor
49ebe88838
Merge pull request #1665 from jchue/patch-7
...
Make minor grammar corrections/updates to async/microtask-queue
2020-01-18 15:20:13 +01:00
tarasyyyk
6c00296f70
Change panel names according to official documentation
2020-01-16 22:12:39 +02:00
Ilya Kantor
01b3ce6665
minor fixes
2020-01-16 18:29:01 +01:00
Marco Dizo
e817e10688
Function return example update
2020-01-16 18:29:21 +08:00
zhangbao
4489949ed4
Fix typo
...
It was not mentioned earlier in the article that “A property can be either an accessor (has get/set methods) or a data property (has a value), not both”
So，we should not say "once again".
2020-01-09 18:16:25 +08:00
Jonathan Chue
642c70153b
Merge branch 'master' into patch-7
2020-01-02 13:46:32 -08:00
Jonathan Chue
3f1812ab11
Update as per @paroche's comments
2020-01-02 13:45:39 -08:00
Peter Roche
14e4e9f96b
Merge pull request #1666 from jchue/patch-8
...
Make minor grammar corrections/updates to async/async-await
2020-01-02 14:41:24 -07:00
Peter Roche
a09d162fe4
Merge pull request #1661 from jchue/patch-3
...
Make minor grammar corrections/updates to async/promise-chaining
2020-01-02 14:23:09 -07:00
Jonathan Chue
0cf57ca7f2
Updated as per @paroche's comments
2020-01-02 12:52:57 -08:00
Jonathan Chue
6495b155f3
Update as per @paroche's comments
2020-01-02 12:44:48 -08:00
Jonathan Chue
95ddbe45a7
Update as per @paroche's comments
2020-01-02 12:41:00 -08:00
Jonathan Chue
48261eb97e
Update as per @paroche's comments
2020-01-02 12:36:56 -08:00
Alexey Pyltsyn
28ed5a3f7d
Merge pull request #1697 from jianlin/patch-1
...
fix typo
2019-12-29 19:17:02 +03:00
Alexey Pyltsyn
87a7232b44
Merge pull request #1698 from karniol/patch-1
...
Fix typo
2019-12-29 19:16:43 +03:00
Ilya Kantor
c2a9c2da58
closure task
2019-12-29 00:33:46 +03:00
Peter Roche
6be43b16a9
Merge pull request #1664 from jchue/patch-6
...
Make minor grammar corrections/updates to async/promisify
2019-12-27 16:42:33 -07:00
Ilya Kantor
fd4f7375b7
reduce improvement
2019-12-27 23:26:02 +03:00
Charlie Karniol
506567b806
Fix typo
2019-12-27 15:57:40 +02:00
jianlin
e3a2051c0e
fix typo
2019-12-27 05:25:15 -08:00
Ilya Kantor
7002488bb5
Merge pull request #1663 from jchue/patch-5
...
Make minor grammar corrections/updates to async/promise-api
2019-12-27 16:11:50 +03:00
Ilya Kantor
94c6f0bbd3
Merge pull request #1662 from jchue/patch-4
...
Make minor grammar corrections/updates to async/promise-error-handling
2019-12-27 16:03:31 +03:00
Ilya Kantor
9236ab3737
Merge pull request #1690 from KennethKinLum/patch-4
...
fix run-on sentence
2019-12-27 16:03:06 +03:00
Ilya Kantor
994390265a
fixes #1669
2019-12-27 11:40:59 +03:00
Ilya Kantor
0716a85fab
Merge pull request #1688 from KennethKinLum/patch-1
...
fixes
2019-12-27 09:21:08 +03:00
Ilya Kantor
461ea30b8c
closes #1689
2019-12-27 09:20:09 +03:00
Kin Lum
3591df7b11
fix run-on sentence
2019-12-26 10:33:44 -08:00
Kin Lum
ac666dec00
fiexes
2019-12-26 09:11:11 -08:00
Ilya Kantor
b015213b7b
minor fixes
2019-12-26 15:52:33 +03:00
Ilya Kantor
e97e43717f
Merge pull request #1678 from sajadhsm/patch-1
...
Add "bigint" to primitive types
2019-12-26 15:32:50 +03:00
Ilya Kantor
2aa36c14ad
Merge pull request #1681 from leviding/patch-1
...
Update 1-js/03-code-quality/05-testing-mocha/pow-2.view/test.js
2019-12-26 15:32:36 +03:00
Ilya Kantor
bdcc7448d6
Merge branch 'master' of https://github.com/iliakan/javascript-tutorial-en
2019-12-26 15:19:43 +03:00
Ilya Kantor
964ed57c42
closure
2019-12-26 14:59:57 +03:00
LeviDing
182ac4b5ae
Update test.js
2019-12-20 10:21:21 +08:00
LeviDing
9e1ef650c5
Update test.js
2019-12-20 10:17:15 +08:00
Alexey Pyltsyn
fde0e1e53f
Merge pull request #1671 from Aissaoui-Ahmed/patch-1
...
Update article.md
2019-12-19 23:15:03 +03:00
Alexey Pyltsyn
213c6c62b6
Merge pull request #1679 from leviding/patch-1
...
fix: type error of 1-js/03-code-quality/05-testing-mocha/article.md
2019-12-19 23:12:59 +03:00
