jeena/sms-translate
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

feat: reorder action buttons (#530)

Browse source 
* feat: never show delete button as action

This makes it slightly harder to accidentally deleted conversations.

* feat: reorder action buttons in chats and main screen

* docs: update changelog
This commit is contained in:
Naveen Singh 2025-09-26 21:49:40 +05:30 • committed by GitHub
parent 4c96bb2056
commit 2280c4581e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 102 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG.md
View file

@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [Unreleased] ## [Unreleased]
### Changed
- Reordered action buttons throughout the app
### Added ### Added
- Ability to save multiple attachments ([#75]) - Ability to save multiple attachments ([#75])

12
app/src/main/res/menu/cab_archived_conversations.xml
View file

@ -3,18 +3,18 @@
xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
tools:ignore="AppCompatResource,AlwaysShowAction"> tools:ignore="AppCompatResource,AlwaysShowAction">
<item
android:id="@+id/cab_delete"
android:icon="@drawable/ic_delete_vector"
android:showAsAction="always"
android:title="@string/delete"
app:showAsAction="always" />
<item <item
android:id="@+id/cab_unarchive" android:id="@+id/cab_unarchive"
android:icon="@drawable/ic_unarchive_vector" android:icon="@drawable/ic_unarchive_vector"
android:showAsAction="ifRoom" android:showAsAction="ifRoom"
android:title="@string/unarchive" android:title="@string/unarchive"
app:showAsAction="ifRoom" /> app:showAsAction="ifRoom" />
<item
android:id="@+id/cab_delete"
android:icon="@drawable/ic_delete_vector"
android:showAsAction="always"
android:title="@string/delete"
app:showAsAction="always" />
<item <item
android:id="@+id/cab_select_all" android:id="@+id/cab_select_all"
android:icon="@drawable/ic_select_all_vector" android:icon="@drawable/ic_select_all_vector"

82
app/src/main/res/menu/cab_conversations.xml
View file

@ -3,50 +3,30 @@
xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
tools:ignore="AppCompatResource,AlwaysShowAction"> tools:ignore="AppCompatResource,AlwaysShowAction">
<item
android:id="@+id/cab_delete"
android:icon="@drawable/ic_delete_vector"
android:showAsAction="always"
android:title="@string/delete"
app:showAsAction="always" />
<item
android:id="@+id/cab_add_number_to_contact"
android:icon="@drawable/ic_add_person_vector"
android:showAsAction="always"
android:title="@string/add_number_to_contact"
app:showAsAction="always" />
<item <item
android:id="@+id/cab_dial_number" android:id="@+id/cab_dial_number"
android:icon="@drawable/ic_phone_vector" android:icon="@drawable/ic_phone_vector"
android:showAsAction="always" android:showAsAction="always"
android:title="@string/dial_number" android:title="@string/dial_number"
app:showAsAction="always" /> app:showAsAction="always" />
<item
android:id="@+id/cab_block_number"
android:icon="@drawable/ic_minus_circle_vector"
android:title="@string/block_number"
app:showAsAction="ifRoom" />
<item <item
android:id="@+id/cab_archive" android:id="@+id/cab_archive"
android:icon="@drawable/ic_archive_vector" android:icon="@drawable/ic_archive_vector"
android:showAsAction="ifRoom" android:showAsAction="always"
android:title="@string/archive" android:title="@string/archive"
app:showAsAction="always" />
<item
android:id="@+id/cab_delete"
android:icon="@drawable/ic_delete_vector"
android:showAsAction="always"
android:title="@string/delete"
app:showAsAction="always" />
<item
android:id="@+id/cab_select_all"
android:icon="@drawable/ic_select_all_vector"
android:showAsAction="ifRoom"
android:title="@string/select_all"
app:showAsAction="ifRoom" /> app:showAsAction="ifRoom" />
<item
android:id="@+id/cab_copy_number"
android:showAsAction="never"
android:title="@string/copy_number_to_clipboard"
app:showAsAction="never" />
<item
android:id="@+id/cab_rename_conversation"
android:icon="@drawable/ic_edit_vector"
android:title="@string/rename_conversation"
app:showAsAction="ifRoom" />
<item
android:id="@+id/cab_conversation_details"
android:showAsAction="never"
android:title="@string/conversation_details"
app:showAsAction="never" />
<item <item
android:id="@+id/cab_mark_as_read" android:id="@+id/cab_mark_as_read"
android:showAsAction="never" android:showAsAction="never"
@ -57,19 +37,41 @@
android:showAsAction="never" android:showAsAction="never"
android:title="@string/mark_as_unread" android:title="@string/mark_as_unread"
app:showAsAction="never" /> app:showAsAction="never" />
<item
android:id="@+id/cab_add_number_to_contact"
android:showAsAction="never"
android:title="@string/add_number_to_contact"
app:showAsAction="never" />
<item
android:id="@+id/cab_copy_number"
android:showAsAction="never"
android:title="@string/copy_number_to_clipboard"
app:showAsAction="never" />
<item
android:id="@+id/cab_rename_conversation"
android:showAsAction="never"
android:title="@string/rename_conversation"
app:showAsAction="never" />
<item
android:id="@+id/cab_conversation_details"
android:showAsAction="never"
android:title="@string/conversation_details"
app:showAsAction="never" />
<item
android:id="@+id/cab_block_number"
android:showAsAction="never"
android:title="@string/block_number"
app:showAsAction="never" />
<item <item
android:id="@+id/cab_pin_conversation" android:id="@+id/cab_pin_conversation"
android:icon="@drawable/ic_pin_filled_vector" android:icon="@drawable/ic_pin_filled_vector"
android:showAsAction="never"
android:title="@string/pin_conversation" android:title="@string/pin_conversation"
app:showAsAction="ifRoom" /> app:showAsAction="never" />
<item <item
android:id="@+id/cab_unpin_conversation" android:id="@+id/cab_unpin_conversation"
android:icon="@drawable/ic_pin_filled_vector" android:icon="@drawable/ic_pin_filled_vector"
android:showAsAction="never"
android:title="@string/unpin_conversation" android:title="@string/unpin_conversation"
app:showAsAction="ifRoom" /> app:showAsAction="never" />
<item
android:id="@+id/cab_select_all"
android:icon="@drawable/ic_select_all_vector"
android:title="@string/select_all"
app:showAsAction="ifRoom" />
</menu> </menu>

35
app/src/main/res/menu/cab_thread.xml
View file

@ -15,27 +15,18 @@
android:showAsAction="always" android:showAsAction="always"
android:title="@string/share" android:title="@string/share"
app:showAsAction="always" /> app:showAsAction="always" />
<item
android:id="@+id/cab_save_as"
android:icon="@drawable/ic_save_vector"
android:showAsAction="ifRoom"
android:title="@string/save_as"
app:showAsAction="ifRoom" />
<item <item
android:id="@+id/cab_delete" android:id="@+id/cab_delete"
android:icon="@drawable/ic_delete_vector" android:icon="@drawable/ic_delete_vector"
android:showAsAction="always" android:showAsAction="always"
android:title="@string/delete" android:title="@string/delete"
app:showAsAction="always" /> app:showAsAction="always" />
<item
android:id="@+id/cab_save_as"
android:icon="@drawable/ic_save_vector"
android:title="@string/save_as"
app:showAsAction="ifRoom" />
<item
android:id="@+id/cab_properties"
android:icon="@drawable/ic_info_vector"
android:title="@string/properties"
app:showAsAction="ifRoom" />
<item
android:id="@+id/cab_restore"
android:showAsAction="never"
android:title="@string/restore"
app:showAsAction="never" />
<item <item
android:id="@+id/cab_forward_message" android:id="@+id/cab_forward_message"
android:showAsAction="never" android:showAsAction="never"
@ -49,6 +40,18 @@
<item <item
android:id="@+id/cab_select_all" android:id="@+id/cab_select_all"
android:icon="@drawable/ic_select_all_vector" android:icon="@drawable/ic_select_all_vector"
android:showAsAction="never"
android:title="@string/select_all" android:title="@string/select_all"
app:showAsAction="ifRoom" /> app:showAsAction="never" />
<item
android:id="@+id/cab_properties"
android:icon="@drawable/ic_info_vector"
android:showAsAction="never"
android:title="@string/properties"
app:showAsAction="never" />
<item
android:id="@+id/cab_restore"
android:showAsAction="never"
android:title="@string/restore"
app:showAsAction="never" />
</menu> </menu>

2
app/src/main/res/menu/menu_main.xml
View file

@ -16,11 +16,13 @@
<item <item
android:id="@+id/settings" android:id="@+id/settings"
android:icon="@drawable/ic_settings_cog_vector" android:icon="@drawable/ic_settings_cog_vector"
android:showAsAction="never"
android:title="@string/settings" android:title="@string/settings"
app:showAsAction="never" /> app:showAsAction="never" />
<item <item
android:id="@+id/about" android:id="@+id/about"
android:icon="@drawable/ic_info_vector" android:icon="@drawable/ic_info_vector"
android:showAsAction="never"
android:title="@string/about" android:title="@string/about"
app:showAsAction="never" /> app:showAsAction="never" />
</menu> </menu>

55
app/src/main/res/menu/menu_thread.xml
View file

@ -2,59 +2,64 @@
<menu xmlns:android="http://schemas.android.com/apk/res/android" <menu xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
tools:ignore="AppCompatResource"> tools:ignore="AppCompatResource,AlwaysShowAction">
<item
android:id="@+id/delete"
android:icon="@drawable/ic_delete_vector"
android:title="@string/delete"
app:showAsAction="always" />
<item <item
android:id="@+id/dial_number" android:id="@+id/dial_number"
android:icon="@drawable/ic_phone_vector" android:icon="@drawable/ic_phone_vector"
android:showAsAction="always"
android:title="@string/dial_number" android:title="@string/dial_number"
app:showAsAction="always" /> app:showAsAction="always" />
<item
android:id="@+id/manage_people"
android:icon="@drawable/ic_add_person_vector"
android:title="@string/add_person"
app:showAsAction="always" />
<item
android:id="@+id/rename_conversation"
android:icon="@drawable/ic_edit_vector"
android:title="@string/rename_conversation"
app:showAsAction="always" />
<item <item
android:id="@+id/archive" android:id="@+id/archive"
android:icon="@drawable/ic_archive_vector" android:icon="@drawable/ic_archive_vector"
android:showAsAction="always"
android:title="@string/archive" android:title="@string/archive"
app:showAsAction="ifRoom" /> app:showAsAction="always" />
<item <item
android:id="@+id/unarchive" android:id="@+id/unarchive"
android:icon="@drawable/ic_unarchive_vector" android:icon="@drawable/ic_unarchive_vector"
android:showAsAction="always"
android:title="@string/unarchive" android:title="@string/unarchive"
app:showAsAction="always" />
<item
android:id="@+id/manage_people"
android:icon="@drawable/ic_add_person_vector"
android:showAsAction="ifRoom"
android:title="@string/add_person"
app:showAsAction="ifRoom" /> app:showAsAction="ifRoom" />
<item
android:id="@+id/add_number_to_contact"
android:title="@string/add_number_to_contact"
app:showAsAction="never" />
<item
android:id="@+id/rename_conversation"
android:showAsAction="never"
android:title="@string/rename_conversation"
app:showAsAction="never" />
<item <item
android:id="@+id/conversation_details" android:id="@+id/conversation_details"
android:showAsAction="never" android:showAsAction="never"
android:title="@string/conversation_details" android:title="@string/conversation_details"
app:showAsAction="never" /> app:showAsAction="never" />
<item <item
android:id="@+id/add_number_to_contact" android:id="@+id/mark_as_unread"
android:title="@string/add_number_to_contact" android:showAsAction="never"
app:showAsAction="ifRoom" /> android:title="@string/mark_as_unread"
app:showAsAction="never" />
<item <item
android:id="@+id/block_number" android:id="@+id/block_number"
android:showAsAction="never" android:showAsAction="never"
android:title="@string/block_number" android:title="@string/block_number"
app:showAsAction="never" /> app:showAsAction="never" />
<item
android:id="@+id/delete"
android:icon="@drawable/ic_delete_vector"
android:showAsAction="never"
android:title="@string/delete"
app:showAsAction="never" />
<item <item
android:id="@+id/restore" android:id="@+id/restore"
android:showAsAction="never" android:showAsAction="never"
android:title="@string/restore_all_messages" android:title="@string/restore_all_messages"
app:showAsAction="never" /> app:showAsAction="never" />
<item
android:id="@+id/mark_as_unread"
android:showAsAction="never"
android:title="@string/mark_as_unread"
app:showAsAction="never" />
</menu> </menu>