jeena/sms-translate
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Don't treat emails as short codes

Browse source 
Closes https://github.com/FossifyOrg/Messages/issues/115
This commit is contained in:
Naveen Singh 2025-01-04 15:52:01 +05:30
parent d4d914abf4
commit 2da3ccad82
No known key found for this signature in database
GPG key ID: AF5D43C216778C0B
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
app/src/main/kotlin/org/fossify/messages/messaging/Messaging.kt
View file

@ -2,6 +2,7 @@ package org.fossify.messages.messaging
import android.content.Context import android.content.Context
import android.telephony.SmsMessage import android.telephony.SmsMessage
import android.util.Patterns
import android.widget.Toast.LENGTH_LONG import android.widget.Toast.LENGTH_LONG
import com.klinker.android.send_message.Settings import com.klinker.android.send_message.Settings
import org.fossify.commons.extensions.showErrorToast import org.fossify.commons.extensions.showErrorToast
@ -99,9 +100,13 @@ fun Context.sendMessageCompat(
* Check if a given "address" is a short code. * Check if a given "address" is a short code.
* There's not much info available on these special numbers, even the wikipedia page (https://en.wikipedia.org/wiki/Short_code) * There's not much info available on these special numbers, even the wikipedia page (https://en.wikipedia.org/wiki/Short_code)
* contains outdated information regarding max number of digits. The exact parameters for short codes can vary by country and by carrier. * contains outdated information regarding max number of digits. The exact parameters for short codes can vary by country and by carrier.
*
* This function simply returns true if the [address] contains at least one letter.
*/ */
fun isShortCodeWithLetters(address: String): Boolean { fun isShortCodeWithLetters(address: String): Boolean {
return address.any { it.isLetter() } val hasLetters = address.any { it.isLetter() }
return if (hasLetters) {
// emails are not short codes: https://github.com/FossifyOrg/Messages/issues/115
!Patterns.EMAIL_ADDRESS.matcher(address).matches()
} else {
true
}
} }