refactor(settings): remove color customization lock and add thank you button (#498)

This commit is contained in:
Naveen Singh 2025-08-25 04:03:16 +05:30 committed by GitHub
parent c0f2c25e32
commit cfc16dd886
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 4 additions and 25 deletions

View file

@ -15,11 +15,9 @@ import org.fossify.commons.extensions.beGoneIf
import org.fossify.commons.extensions.beVisible
import org.fossify.commons.extensions.beVisibleIf
import org.fossify.commons.extensions.getBlockedNumbers
import org.fossify.commons.extensions.getCustomizeColorsString
import org.fossify.commons.extensions.getFontSizeText
import org.fossify.commons.extensions.getProperPrimaryColor
import org.fossify.commons.extensions.isOrWasThankYouInstalled
import org.fossify.commons.extensions.launchPurchaseThankYouIntent
import org.fossify.commons.extensions.toast
import org.fossify.commons.extensions.updateTextColors
import org.fossify.commons.extensions.viewBinding
@ -108,7 +106,6 @@ class SettingsActivity : SimpleActivity() {
super.onResume()
setupToolbar(binding.settingsToolbar, NavigationIcon.Arrow)
setupPurchaseThankYou()
setupCustomizeColors()
setupCustomizeNotifications()
setupUseEnglish()
@ -170,17 +167,9 @@ class SettingsActivity : SimpleActivity() {
blockedNumbersAtPause = getBlockedNumbers().hashCode()
}
private fun setupPurchaseThankYou() = binding.apply {
settingsPurchaseThankYouHolder.beGoneIf(isOrWasThankYouInstalled())
settingsPurchaseThankYouHolder.setOnClickListener {
launchPurchaseThankYouIntent()
}
}
private fun setupCustomizeColors() = binding.apply {
settingsColorCustomizationLabel.text = getCustomizeColorsString()
settingsColorCustomizationHolder.setOnClickListener {
handleCustomizeColorsClick()
startCustomizationActivity()
}
}

View file

@ -63,20 +63,10 @@
android:layout_height="wrap_content"
android:text="@string/general_settings" />
<RelativeLayout
<org.fossify.commons.views.PurchaseThankYouItem
android:id="@+id/settings_purchase_thank_you_holder"
style="@style/SettingsHolderTextViewOneLinerStyle"
android:layout_width="match_parent"
android:layout_height="wrap_content">
<org.fossify.commons.views.MyTextView
android:id="@+id/settings_purchase_thank_you"
style="@style/SettingsTextLabelStyle"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:text="@string/purchase_simple_thank_you" />
</RelativeLayout>
android:layout_height="wrap_content"/>
<RelativeLayout
android:id="@+id/settings_use_english_holder"

View file

@ -16,7 +16,7 @@ eventbus = "3.3.1"
#Room
room = "2.7.2"
#Fossify
commons = "4.4.2"
commons = "5.0.0"
android-smsmms = "c3e678befd"
indicator-fast-scroll = "4524cd0b61"
#Gradle