jeena/telldus
1
0
Fork 0
Code Issues Pull requests Projects Packages Wiki Activity Actions

Missing username in TODO according to Google style guidelines "readability/todo"

Browse source
This commit is contained in:
Micke Prag 2012-06-15 17:18:05 +02:00
parent a165e414fd
commit 6688f44084
7 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
telldus-core/client/Client.cpp
View file

@ -166,11 +166,11 @@ std::wstring Client::sendToService(const Message &msg) {
msleep(500);
continue; // retry
}
readData = s.read(8000); // TODO changed to 10000 from 5000, how much does this do...?
readData = s.read(8000); // TODO(stefan) changed to 10000 from 5000, how much does this do...?
if(readData == L"") {
msleep(500);
continue; // TODO can we be really sure it SHOULD be anything?
// TODO perhaps break here instead?
continue; // TODO(stefan): can we be really sure it SHOULD be anything?
// TODO(stefan): perhaps break here instead?
}
if (!s.isConnected()) { // Connection failed sometime during operation...

2
telldus-core/common/Socket_unix.cpp
View file

@ -121,7 +121,7 @@ std::wstring Socket::read(int timeout) {
void Socket::stopReadWait() {
TelldusCore::MutexLocker locker(&d->mutex);
d->connected = false;
// TODO somehow signal the socket here?
// TODO(stefan): somehow signal the socket here?
}
void Socket::write(const std::wstring &msg) {

2
telldus-core/common/Strings.cpp
View file

@ -101,7 +101,7 @@ bool TelldusCore::comparei(std::wstring stringA, std::wstring stringB) {
std::wstring TelldusCore::intToWstring(int value) {
#ifdef _WINDOWS
// no stream used
// TODO! Make effective and safe...
// TODO(stefan): Make effective and safe...
wchar_t numstr[21]; // enough to hold all numbers up to 64-bits
_itow_s(value, numstr, sizeof(numstr), 10);
std::wstring newstring(numstr);

4
telldus-core/service/ControllerManager.cpp
View file

@ -174,7 +174,7 @@ void ControllerManager::loadControllers() {
if (!controllerId) {
controllerId = d->settings.addNode(Settings::Controller);
if(controllerId < 0) {
// TODO: How to handle this?
// TODO(micke): How to handle this?
continue;
}
isNew = true;
@ -333,7 +333,7 @@ int ControllerManager::setControllerValue(int id, const std::wstring &name, cons
d->settings.setName(Settings::Controller, id, value);
signalControllerEvent(id, TELLSTICK_DEVICE_CHANGED, TELLSTICK_CHANGE_NAME, value);
} else {
return TELLSTICK_ERROR_SYNTAX; // TODO: Is this the best error?
return TELLSTICK_ERROR_SYNTAX; // TODO(micke): Is this the best error?
}
return TELLSTICK_SUCCESS;
}

2
telldus-core/service/DeviceManager.cpp
View file

@ -487,7 +487,7 @@ int DeviceManager::doGroupAction(const std::wstring devices, const int action, c
if(childType == TELLSTICK_TYPE_DEVICE) {
deviceReturnValue = doAction(deviceId, action, data);
} else if(childType == TELLSTICK_TYPE_SCENE) {
deviceReturnValue = doGroupAction(DeviceManager::getDeviceParameter(deviceId, L"devices", L""), action, data, childType, deviceId, duplicateDeviceIds); // TODO make scenes infinite loops-safe
deviceReturnValue = doGroupAction(DeviceManager::getDeviceParameter(deviceId, L"devices", L""), action, data, childType, deviceId, duplicateDeviceIds); // TODO(stefan) make scenes infinite loops-safe
} else {
// group (in group)
deviceReturnValue = doGroupAction(DeviceManager::getDeviceParameter(deviceId, L"devices", L""), action, data, childType, deviceId, duplicateDeviceIds);

2
telldus-core/service/ProtocolNexa.cpp
View file

@ -11,7 +11,7 @@
#include "service/TellStick.h"
#include "common/Strings.h"
int ProtocolNexa::lastArctecCodeSwitchWasTurnOff = 0; // TODO, always removing first turnon now, make more flexible (waveman too)
int ProtocolNexa::lastArctecCodeSwitchWasTurnOff = 0; // TODO(stefan): always removing first turnon now, make more flexible (waveman too)
int ProtocolNexa::methods() const {
if (TelldusCore::comparei(model(), L"codeswitch")) {

2
telldus-core/service/ProtocolOregon.cpp
View file

@ -103,7 +103,7 @@ std::string ProtocolOregon::decode1A2D(const std::string &data) {
checksum += 0x1 + 0xA + 0x2 + 0xD - 0xA;
// TODO: Find out how checksum2 works
// TODO(micke): Find out how checksum2 works
if (checksum != checksum1) {
return "";
}