Commit graph

2017 commits

Author SHA1 Message Date
Micke Prag
2fc9d470dd If an else has a brace on one side, it should have it on both according to Google style guidelines "readability/braces" 2012-06-19 12:30:52 +02:00
Micke Prag
31ee1880ad Use sizeof(varname) instead of sizeof(type) according to Google style guidelines "runtime/sizeof" 2012-06-19 12:30:52 +02:00
Micke Prag
1ac3fc25e0 Use pointers when passing references according to Google style guidelines "runtime/references" 2012-06-19 12:30:52 +02:00
Micke Prag
3dcc7a04ba Use int16/int64/etc, rather than the C types according to Google style guidelines "runtime/int" 2012-06-19 12:30:52 +02:00
Micke Prag
6666dc0294 Do not use namespace using-directives according to Google style guidelines "build/namespaces" 2012-06-19 12:30:51 +02:00
Micke Prag
67d8bf7fb0 We need spaces after semicolon in for loops according to Google style guidelines "whitespace/semicolon" 2012-06-19 12:30:51 +02:00
Micke Prag
e7bb22cf34 We need spaces surrounding operators according to Google style guidelines "whitespace/operators" 2012-06-19 12:30:51 +02:00
Micke Prag
a01b42b4d7 An else should appear on the same line as the preceding } according to Google style guidelines "whitespace/newline" 2012-06-19 12:30:51 +02:00
Micke Prag
1f9a069df7 Remove extra spaces at end of line according to Google style guidelines "whitespace/end_of_line" 2012-06-19 12:30:51 +02:00
Micke Prag
dc357ddeca Remove extra blank lines according to Google style guidelines "whitespace/blank_line" 2012-06-19 12:30:51 +02:00
Micke Prag
110dcc2c57 Should have spaces after comma according to Google style guidelines "whitespace/comma" 2012-06-19 12:30:51 +02:00
Micke Prag
3a0cee353a Fix include header order according to Google style guidelines "build/include_order" 2012-06-19 12:30:50 +02:00
Micke Prag
75f21588e5 Should have a space between // and comment "whitespace/comments" 2012-06-19 12:30:50 +02:00
Micke Prag
e1608f94a8 { should almost always be at the end of the previous line, according to Google style guidelines "whitespace/braces" 2012-06-19 12:30:50 +02:00
Micke Prag
78444e20b9 Add #include <string> for string, according to Google style guidelines "build/include_what_you_use" 2012-06-19 12:30:50 +02:00
Micke Prag
a4dfd27d35 Single-argument constructors should be marked explicit. According to
Google style guideline "runtime/explicit"
2012-06-19 12:30:50 +02:00
Micke Prag
0d25f0b389 Fix #ifndef header guard style, according to Google style guidelines
"build/header_guard"
2012-06-19 12:30:50 +02:00
Micke Prag
8d0228ced2 Add copyright message according to Google style guidelines "legal/copyright" 2012-06-19 12:30:50 +02:00
Micke Prag
5b5be387cd Include the directory when naming .h files. According to Google style guideline "build/include". 2012-06-19 12:30:49 +02:00
Micke Prag
3101fd0969 Add test for checking that tab is used for indentation 2012-06-19 12:30:49 +02:00
Micke Prag
d3b75fc4f6 Change the test so a tab character before a braces is ok 2012-06-18 16:27:45 +02:00
Micke Prag
506c740d81 Add Google style guideline check tool: cpplint 2012-06-08 16:18:51 +02:00
Micke Prag
488ab8c754 The function close() is declared in unistd.h. We must include this since it might not be pulled in by other headers on all platforms. Closes #216 2012-06-08 12:28:13 +02:00
Micke Prag
4af5c5b658 Check that the option we set in Settings::setStringSetting() actually
exists before write when using libConfuse. Writing to a non existing
option makes telldusd SIGABRT. Closes #207.
2012-06-01 15:28:59 +02:00
Micke Prag
d4b46c71ec Add some different xPL implementations done by Telldus 2012-05-29 14:18:28 +02:00
Micke Prag
deebf2045e Add quit key shortcut (ctrl+q) 2012-04-16 12:03:47 +02:00
Micke Prag
e6fc4d3034 Merge remote branch 'stromnet/stromnet-master' 2012-04-13 11:31:49 +02:00
Micke Prag
1e6767fa65 Return an appropriate error code instead of true/false in tdUnregisterCallback(), closes #200 2012-04-13 11:22:47 +02:00
Micke Prag
8babf9913d If the protocol is not valid, return TELLSTICK_ERROR_CONFIG_SYNTAX instead of TELLSTICK_ERROR_UNKNOWN. Closes #119 2012-04-13 11:10:27 +02:00
Micke Prag
12eb097ce4 Add error message for syntax error in the configuration file, see #119 2012-04-13 10:56:36 +02:00
Micke Prag
eb95ffe8a5 Fix missing separator. 2012-04-13 10:55:24 +02:00
Micke Prag
c137bca9fe Only log SIGPIPE as debug messages. Closes #194 2012-04-13 10:24:11 +02:00
Johan Ström
6670f627a0 Race-fix for OSX ControllerListener.
If the destructor was called very close (in time) after the constructor
was called, we'd get a race where gRunLoop was not inited properly, and
when trying to release it we crashed with EXC_BAD_ACCESS.

An example when this would happen is if the user SIGINTs while starting
up. The ControllerManager can be quite slow (seconds) to init sometimes,
and if we'd SIGINT while waiting for it, the ControllerListener ctor
would be called after, the mainloop would be skipped, and then the dtor
would be called -> triggering crash.
2012-04-09 21:28:39 +02:00
Micke Prag
f57eebad74 Merge remote branch 'erijo/get-controller-value'. This closes #202.
Conflicts:
	telldus-core/client/telldus-core.cpp
2012-03-30 16:49:42 +02:00
Micke Prag
c77fd899a1 Merge branch 'misc-fixes' 2012-03-30 16:29:59 +02:00
Micke Prag
957921b01e Merge branch 'docs' 2012-03-30 14:55:46 +02:00
Micke Prag
db1d6c4d47 Fix coding style in CMakeLists.txt 2012-03-30 14:55:34 +02:00
Micke Prag
0aab73dcbe Cleanup the STATE_INSTALL_DIR variable in CMake. Only define it one time 2012-03-30 14:03:34 +02:00
Micke Prag
748d19c58c Merge pull request #1 from erijo/confuse-paths
Make settings paths set in cmake be used by telldusd
2012-03-30 04:59:52 -07:00
Erik Johansson
3bedad336a Make tdadmin handle only one parameter w/o crashing
Fixes SIGSEGV when running tdadmin - (ticket #194).
2012-03-21 16:20:23 +01:00
Erik Johansson
5492623ecd Avoid one extra strlen 2012-03-20 16:37:56 +01:00
Erik Johansson
2eb0453f4d Clarify that controller availability is a string 2012-03-19 10:57:56 +01:00
Erik Johansson
da0371d803 Minor doc fixes 2012-03-19 10:55:35 +01:00
Erik Johansson
bd0e01bfad Correct spelling in error message 2012-03-19 10:50:43 +01:00
Erik Johansson
8ace17c8f0 Reformat the doxygen comment 2012-03-19 10:50:11 +01:00
Erik Johansson
5061c759f3 Minor doc cleanups 2012-03-19 10:00:05 +01:00
Erik Johansson
0d84d52ebe Document TDControllerEvent 2012-03-17 19:18:56 +01:00
Erik Johansson
902c12d88d The controller added callback should pass the controller type
This unifies the behavior between loadControllers() and
loadStoredControllers().
2012-03-17 19:16:27 +01:00
Erik Johansson
ee4d821a7a Document TDSensorEvent 2012-03-17 19:02:17 +01:00
Erik Johansson
034b5a03e6 Document TDRawDeviceEvent 2012-03-17 18:55:44 +01:00