Commit graph

2046 commits

Author SHA1 Message Date
Micke Prag
83dbd675cf Add python compiled files to gitignore 2012-06-21 17:21:16 +02:00
Micke Prag
d22793ed12 We cannot iterate over a QHash since the order is by design not guaranteed. Loop using a counter instead 2012-06-21 11:53:11 +02:00
Micke Prag
246e043551 Fix typo in deviceSettings index 2012-06-21 11:43:39 +02:00
Micke Prag
ed9d1237b4 Add device Anslut selflearning on/off 2012-06-20 17:15:53 +02:00
Micke Prag
61d0b2ac09 Implement protocol Comen by hardcoding the last to bits in the housecode 2012-06-20 17:15:26 +02:00
Micke Prag
d6dcd11973 Protocol::getStringParameter() and Protocol::getIntParameter() should be virtual so they can be overriden by a protocol 2012-06-20 17:14:10 +02:00
Micke Prag
1ea754da3d Bugfix, all the parameters for a device tried to be saved as non parameters 2012-06-20 17:12:30 +02:00
Micke Prag
9eac84fb4a Remove sscanf() from ProtocolSartano and add a unittest for ProtocolSartano::decodeData() 2012-06-20 15:22:10 +02:00
Micke Prag
ddfb87f45d Remove sscanf() from ProtocolEverflourish and add a unittest for ProtocolEverflourish::decodeData() 2012-06-20 15:21:29 +02:00
Micke Prag
b50e9dd3d5 Remove sscanf() from ProtocolX10 and add a unittest for ProtocolX10::decodeData() 2012-06-20 14:18:29 +02:00
Micke Prag
41816f36a3 Configure SettingsConfusePaths.h in the correct section in CMakeLists.txt 2012-06-20 12:22:03 +02:00
Micke Prag
264b92889a Add unittest for ProtocolNexa::decodeData() 2012-06-20 12:20:23 +02:00
Micke Prag
ae7b9b8c1a If we enable testing, build TelldusService as a static library that can be used by the TestRunner 2012-06-20 12:18:50 +02:00
Micke Prag
6e47588096 Add comment on why we disable some of the default tests 2012-06-19 16:51:35 +02:00
Micke Prag
ffebd4ed4c Enable test whitespace/use_tab_for_indentaion and disable test runtime/rtti 2012-06-19 16:51:18 +02:00
Micke Prag
c97c88ba8d Extra check for the value in Nexa device settings. This could lead to a potential crash otherwise 2012-06-19 16:50:21 +02:00
Micke Prag
39c6bb012e Use dynamic_cast instead of reinterpret_cast for our events 2012-06-19 16:49:26 +02:00
Micke Prag
7b82e529cc Convert sscanf in ProtocolNexa and ProtocolWaveman to a faster and platform independent implementation 2012-06-19 16:48:44 +02:00
Micke Prag
818ae8abed Rename ControllerMessage::getIntParameter() to ControllerMessage::getInt64Parameter() 2012-06-19 16:47:01 +02:00
Micke Prag
dbb11602ec Temporarily suppress cpplint errors "runtime/printf" for sscanf(). We should prpbably remove them later 2012-06-19 16:23:36 +02:00
Micke Prag
58bf51a6e8 Convert strcpy to snprintf. This is better according to Google style guidelines "runtime/printf" 2012-06-19 16:18:44 +02:00
Micke Prag
77b128f2fd Add exception for using getgwnam() and getpwnam(). This is safe so early in the startup 2012-06-19 14:40:00 +02:00
Micke Prag
c26efc1305 Convert strtok() to strtok_r() for improved thread safety. 2012-06-19 14:13:18 +02:00
Micke Prag
d2332cb605 Convert non utf-8 characters in ProtocolIkea 2012-06-19 14:02:38 +02:00
Micke Prag
6067c776c5 Since we use tabs for indentation, convert to one line instead 2012-06-19 12:30:52 +02:00
Micke Prag
6688f44084 Missing username in TODO according to Google style guidelines "readability/todo" 2012-06-19 12:30:52 +02:00
Micke Prag
a165e414fd Streams are highly discouraged according to Google style guidelines "readability/streams" 2012-06-19 12:30:52 +02:00
Micke Prag
9352ae0807 All parameters should be named in a function according to Google style guidelines "readability/function" 2012-06-19 12:30:52 +02:00
Micke Prag
5d2e3f33c8 Use C++ casting instead of C casting according to Google style guidelines "readability/casting" 2012-06-19 12:30:52 +02:00
Micke Prag
2fc9d470dd If an else has a brace on one side, it should have it on both according to Google style guidelines "readability/braces" 2012-06-19 12:30:52 +02:00
Micke Prag
31ee1880ad Use sizeof(varname) instead of sizeof(type) according to Google style guidelines "runtime/sizeof" 2012-06-19 12:30:52 +02:00
Micke Prag
1ac3fc25e0 Use pointers when passing references according to Google style guidelines "runtime/references" 2012-06-19 12:30:52 +02:00
Micke Prag
3dcc7a04ba Use int16/int64/etc, rather than the C types according to Google style guidelines "runtime/int" 2012-06-19 12:30:52 +02:00
Micke Prag
6666dc0294 Do not use namespace using-directives according to Google style guidelines "build/namespaces" 2012-06-19 12:30:51 +02:00
Micke Prag
67d8bf7fb0 We need spaces after semicolon in for loops according to Google style guidelines "whitespace/semicolon" 2012-06-19 12:30:51 +02:00
Micke Prag
e7bb22cf34 We need spaces surrounding operators according to Google style guidelines "whitespace/operators" 2012-06-19 12:30:51 +02:00
Micke Prag
a01b42b4d7 An else should appear on the same line as the preceding } according to Google style guidelines "whitespace/newline" 2012-06-19 12:30:51 +02:00
Micke Prag
1f9a069df7 Remove extra spaces at end of line according to Google style guidelines "whitespace/end_of_line" 2012-06-19 12:30:51 +02:00
Micke Prag
dc357ddeca Remove extra blank lines according to Google style guidelines "whitespace/blank_line" 2012-06-19 12:30:51 +02:00
Micke Prag
110dcc2c57 Should have spaces after comma according to Google style guidelines "whitespace/comma" 2012-06-19 12:30:51 +02:00
Micke Prag
3a0cee353a Fix include header order according to Google style guidelines "build/include_order" 2012-06-19 12:30:50 +02:00
Micke Prag
75f21588e5 Should have a space between // and comment "whitespace/comments" 2012-06-19 12:30:50 +02:00
Micke Prag
e1608f94a8 { should almost always be at the end of the previous line, according to Google style guidelines "whitespace/braces" 2012-06-19 12:30:50 +02:00
Micke Prag
78444e20b9 Add #include <string> for string, according to Google style guidelines "build/include_what_you_use" 2012-06-19 12:30:50 +02:00
Micke Prag
a4dfd27d35 Single-argument constructors should be marked explicit. According to
Google style guideline "runtime/explicit"
2012-06-19 12:30:50 +02:00
Micke Prag
0d25f0b389 Fix #ifndef header guard style, according to Google style guidelines
"build/header_guard"
2012-06-19 12:30:50 +02:00
Micke Prag
8d0228ced2 Add copyright message according to Google style guidelines "legal/copyright" 2012-06-19 12:30:50 +02:00
Micke Prag
5b5be387cd Include the directory when naming .h files. According to Google style guideline "build/include". 2012-06-19 12:30:49 +02:00
Micke Prag
3101fd0969 Add test for checking that tab is used for indentation 2012-06-19 12:30:49 +02:00
Micke Prag
d3b75fc4f6 Change the test so a tab character before a braces is ok 2012-06-18 16:27:45 +02:00